Skip to content

Add response trailers for bandwidth limit filter#18040

Closed
zhiyong-gayang wants to merge 122 commits intoenvoyproxy:mainfrom
zhiyong-gayang:main
Closed

Add response trailers for bandwidth limit filter#18040
zhiyong-gayang wants to merge 122 commits intoenvoyproxy:mainfrom
zhiyong-gayang:main

Conversation

@zhiyong-gayang
Copy link
Copy Markdown
Contributor

@zhiyong-gayang zhiyong-gayang commented Sep 9, 2021

I want use this PR to discuss whether this change is acceptable. If it's acceptable, I will create another PR with the implementations.

Commit Message: Add response trailers for the bandwidth limit filter delays.
Additional Description: This is useful when downstream want to understand how much delays that is caused by bandwidth limit filter.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Sep 9, 2021

Hi @garyyang2002, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #18040 was opened by garyyang2002.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Sep 9, 2021

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #18040 was opened by garyyang2002.

see: more, trace.

@lizan
Copy link
Copy Markdown
Member

lizan commented Sep 10, 2021

cc @nitgoy @mattklein123 @yanavlasov @tonya11en (bandwidth limit filter owners)

@nitgoy
Copy link
Copy Markdown
Contributor

nitgoy commented Sep 13, 2021

This is a feature that @garyyang2002 added to our internal fork at Microsoft based on user feedback. He's trying to see if it makes sense to merge it back to envoy upstream. @mattklein123, @yanavlasov please chime in.

@yanavlasov
Copy link
Copy Markdown
Contributor

yanavlasov commented Sep 21, 2021

Sorry for the late response. Yes, I think it makes sense to merge it upstream.

@mattklein123 mattklein123 self-assigned this Sep 21, 2021
@mattklein123
Copy link
Copy Markdown
Member

mattklein123 commented Sep 21, 2021

Sure sounds good. I think the API and the implementation can come in a single PR so please add the implementation to this or just close and open a new one with the implementation.

/wait

@zhiyong-gayang
add response trailers for bandwidth limit filter
4ed93ad 
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang
fix format
40730f8 
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang zhiyong-gayang changed the title Add response trailers for bandwidth limit filter (API Changes only) Add response trailers for bandwidth limit filter Sep 26, 2021
zhiyong-gayang and others added 11 commits September 26, 2021 14:55
@zhiyong-gayang
fix comment
ddc3b33 
Signed-off-by: gayang <gayang@microsoft.com>
@phlax @zhiyong-gayang
protos: Cleanup unused imports (#18024)
8e8b6f1 
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: gayang <gayang@microsoft.com>
@esmet @zhiyong-gayang
Fix a typo (#18045)
0ebd6e6 
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: gayang <gayang@microsoft.com>
@wrowe @zhiyong-gayang
Update OWNERS.md (#18054)
9038b82 
Request add to Security Team for research, platform portability and liason to our upstream dependencies.

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: gayang <gayang@microsoft.com>
@alyssawilk @zhiyong-gayang
docs: api docs update (#17966)
fdee7c6 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: gayang <gayang@microsoft.com>
@moderation @zhiyong-gayang
Update base Alpine and Distroless container images. (#18062)
a587452 
Signed-off-by: Michael Payne <michael@sooper.org>
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang
Wrong past participle words fixed in comments (#18037)
212cbe6 
Signed-off-by: Le Yao <le.yao@intel.com>
Signed-off-by: gayang <gayang@microsoft.com>
@alyssawilk @zhiyong-gayang
decompressor: fixing a bug for requests with added trailers (#18055)
ac396dd 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: gayang <gayang@microsoft.com>
@junr03 @zhiyong-gayang
dns cache: log event with addresses on resolution (#18036)
267b121 
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: gayang <gayang@microsoft.com>
@adamkotwasinski @zhiyong-gayang
Kafka-mesh filter (#11936)
f44c757 
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: gayang <gayang@microsoft.com>
@phlax @zhiyong-gayang
bazel: Make use of new incremental pip installer (#18026)
6465014 
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: gayang <gayang@microsoft.com>
danzh2010 and others added 16 commits September 26, 2021 14:55
@danzh2010 @zhiyong-gayang
quiche: support inplace filter chain update (#17988)
e47e557 
Commit Message: updateListenerConfig() and onFilterChainDraining() to ActiveListener interface and implement them in ActiveQuicListener. Unblock listener update for UDP listener.

Risk Level: high, touches LDS.
Testing: new integration tests
Fixes #13115
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: gayang <gayang@microsoft.com>
@zirain @zhiyong-gayang
add ratelimit log (#17902)
8ea36c4 
Signed-off-by: zirain <zirain2009@hotmail.com>
Signed-off-by: gayang <gayang@microsoft.com>
@junr03 @zhiyong-gayang
dns cache: upgrade event (#18247)
5388ccb 
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: gayang <gayang@microsoft.com>
@snowp @zhiyong-gayang
network: set failure reason for transport socket connect timeout (#18244
90d7e99 
)

Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: gayang <gayang@microsoft.com>
@YaoZengzeng @zhiyong-gayang
log: make log of listener filters consistent. (#18232)
6914d2d 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: gayang <gayang@microsoft.com>
@alyssawilk @zhiyong-gayang
test: moving redirect extensions test out of core (#18214)
e094ee9 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: gayang <gayang@microsoft.com>
@esmet @zhiyong-gayang
ext_authz: add dynamic_metadata_matchers and use them in the ext_auth…
0281416 
…z HTTP implementation (#17895)

This allows for dynamic metadata when using an HTTP authorization service. Currently, it is only possible to set dynamic metadata using a gRPC authorization service.

Risk Level: low, new opt-in feature in an extension
Testing: unit tests
Docs Changes: proto definitions documented
Release Notes: ext_authz: added :ref:dynamic_metadata_from_headers <envoy_v3_api_field_extensions.filters.http.ext_authz.v3.AuthorizationResponse.dynamic_metadata_from_headers> to support emitting dynamic metadata from headers returned by an external authorization service via HTTP.

Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: gayang <gayang@microsoft.com>
@agrawroh @zhiyong-gayang
proto: add a new field called append_action in the HeaderValueOption (#…
d6c3c2f 
…18246)

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: gayang <gayang@microsoft.com>
@stevenzzzz @zhiyong-gayang
Reuse the ConfigImpl held by RdsRouteConfigProviderImpl in SRDS (#18241)
13a1beb 
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: gayang <gayang@microsoft.com>
@gbrail @zhiyong-gayang
ext_proc: Cache the gRPC client (#18166)
513c2ad 
Signed-off-by: Gregory Brail <gregbrail@google.com>
Signed-off-by: gayang <gayang@microsoft.com>
@wbpcode @zhiyong-gayang
fix possible use-after-free introduced by the cross-priority host map…
cd72c55 
… updates in the thread aware lb (#18253)

Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: gayang <gayang@microsoft.com>
@phlax @zhiyong-gayang
docs: Consolidate build rules (#18142)
f05d29e 
* docs: Consolidate build rules
* add-todo

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: gayang <gayang@microsoft.com>
@RyanTheOptimist @zhiyong-gayang
coverage: exclude a guarddog test from coverage (#18255)
85dd89d 
This is a clone of #18252 but with the formatting fixed.

Risk Level: None - test only
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang
add response trailers for bandwidth limit filter
fb6b540 
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang
fix format
c5c25d1 
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang
Merge branch 'main' of https://github.com/garyyang2002/envoy into main
a246b62 
Signed-off-by: gayang <gayang@microsoft.com>
@zhiyong-gayang
Copy link
Copy Markdown
Contributor Author

zhiyong-gayang commented Sep 28, 2021

Created a new PR: #18267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssawilk alyssawilk Awaiting requested review from alyssawilk

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@yanavlasov yanavlasov Awaiting requested review from yanavlasov yanavlasov is a code owner

@antoniovicente antoniovicente Awaiting requested review from antoniovicente

@asraa asraa Awaiting requested review from asraa

@dio dio Awaiting requested review from dio

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway is a code owner

@htuch htuch Awaiting requested review from htuch

@jmarantz jmarantz Awaiting requested review from jmarantz

@junr03 junr03 Awaiting requested review from junr03

@lizan lizan Awaiting requested review from lizan

@mathetake mathetake Awaiting requested review from mathetake

@rojkov rojkov Awaiting requested review from rojkov

@snowp snowp Awaiting requested review from snowp

@zuercher zuercher Awaiting requested review from zuercher zuercher is a code owner

Assignees

@lizan lizan

@mattklein123 mattklein123

Labels

api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.