docs: Consolidate build rules#18142
Merged
wrowe merged 2 commits intoenvoyproxy:mainfrom Sep 24, 2021
Merged
Conversation
phlax
force-pushed
the
docs-consolidation
branch
from
b9ed526 to
97d5a82
Compare
repokitteh-read-only
bot
added
the
deps
phlax
commented
Sep 16, 2021
phlax
changed the title
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docs-consolidation
branch
from
97d5a82 to
2334967
Compare
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
wrowe
previously approved these changes
Sep 22, 2021
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
This is fine, do you want to drop in a todo/comment about the unused/undeployed rule?
Member
Author
yep, ill do it now |
soulxu
pushed a commit
to soulxu/envoy
that referenced
this pull request
Oct 16, 2021
* docs: Consolidate build rules * add-todo Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: docs: Consolidate build rules
Additional Description:
This is the first of a few PRs to cleanup/consolidate the docs build
This one:
rules_pkgto the newest versionpkg_filesandpkg_filegroupin follow up prs i intend to:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]