dns cache: log event with addresses on resolution#18036
Merged
mattklein123 merged 3 commits intomainfrom Sep 10, 2021
Merged
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
|
LGTM but needs CI fix. /wait |
Member
Author
|
@mattklein123 that's what I thought, I couldn't see a definition of front for that proto type but for some reason my build passed locally. Fixing |
mattklein123
previously approved these changes
Sep 9, 2021
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
approved these changes
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: adds addresses to finish resolution log. Moves to ENVOY_LOG_EVENT macro.
Risk Level: low
Signed-off-by: Jose Nino jnino@lyft.com