decompressor: fixing a bug for requests with added trailers#18055
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Sep 10, 2021
Merged
decompressor: fixing a bug for requests with added trailers#18055mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
rgs1
approved these changes
Sep 9, 2021
Member
rgs1
left a comment
rgs1
left a comment
There was a problem hiding this comment.
Thanks! Adding it to our build now.
Member
|
Oops: |
rgs1
suggested changes
Sep 9, 2021
|
|
||
| * access log: fix ``%UPSTREAM_CLUSTER%`` when used in http upstream access logs. Previously, it was always logging as an unset value. | ||
| * access log: fix ``%UPSTREAM_CLUSTER%`` when used in http upstream access logs. Previously, it was always logging as an unset value. | ||
| * compressor: fix a bug where if trailers were added and a subsequent filter paused the filter chain, the request could be stalled. This behavior can be reverted by setting `envoy.reloadable_features.fix_added_trailers` to false. |
Member
There was a problem hiding this comment.
sort and you need two back ticks these days (see UPSTREAM_CLUSTER above)
mattklein123
approved these changes
Sep 9, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Sweet, thanks for the quick turnaround!
rgs1
approved these changes
Sep 9, 2021
tyxia
pushed a commit
to tyxia/envoy
that referenced
this pull request
Sep 21, 2021
…xy#18055) Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: alyssawilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Medium: filter chain change but only (?) for added trailers
Testing: new integration test
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.fix_added_trailers
h/t to @rgs1 for the bug report, and writing the integration test!
Co-authored-by: @rgs1