Skip to content

proto: add a new field called append_action in the HeaderValueOption#18246

Merged
mattklein123 merged 7 commits intoenvoyproxy:mainfrom
agrawroh:add-header-if-absent-api
Sep 24, 2021
Merged

proto: add a new field called append_action in the HeaderValueOption#18246
mattklein123 merged 7 commits intoenvoyproxy:mainfrom
agrawroh:add-header-if-absent-api

Conversation

@agrawroh
Copy link
Copy Markdown
Member

@agrawroh agrawroh commented Sep 23, 2021 •
edited
Loading

This PR adds a new field called append_action to the HeaderValueOption. This is just the .proto change being done in the preparation for #18130. We'll mark the existing append field as deprecated in #18310.

append_action extends the header matcher by describing what append action to take indicating whether:

  1. The formatted header should be added only if it's not already present;
  2. New value should be appended to the existing values if header already exists; or
  3. New value should be overwritten by discarding any existing values if header already exists;

Commit Message: add a new field called append_action in the HeaderValueOption.
Additional Description: Adds a new field called append_action in HeaderValueOption which will ultimately deprecate the old append and will extend the existing matcher functionality.
Risk Level: -
Testing: -
Docs Changes: N/A (Will be done in #18130)
Release Notes: N/A (Will be done in #18130)
Platform Specific Features: N/A

Signed-off-by: Rohit Agrawal rohit.agrawal@databricks.com

@agrawroh
proto: add a new field called append_action in the HeaderValueOption
1a745ac 
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Sep 23, 2021

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #18246 was opened by agrawroh.

see: more, trace.

@agrawroh agrawroh mentioned this pull request Sep 23, 2021
Closed
mattklein123
mattklein123 reviewed Sep 24, 2021
View reviewed changes
api/envoy/config/core/v3/base.proto
google.protobuf.BoolValue append = 2;

// Describes the action taken to append/overwrite the given value for an existing header
// or to only add this header if it's absent. Value defaults to :ref:`APPEND_IF_EXISTS_OR_ADD<envoy_v3_api_enum_value_config.core.v3.HeaderValueOption.HeaderAppendAction.APPEND_IF_EXISTS_OR_ADD>`.
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark this [#not-implemented-hide] just in case it takes a bit for the other PR to land? Thank you.

/wait

Copy link
Copy Markdown
Member Author

@agrawroh agrawroh Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@agrawroh
Remove Reference Not Yet Implemented
151843f 
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@agrawroh
Copy link
Copy Markdown
Member Author

agrawroh commented Sep 24, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Sep 24, 2021

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18246 (comment) was created by @agrawroh.

see: more, trace.

@agrawroh
Copy link
Copy Markdown
Member Author

agrawroh commented Sep 24, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Sep 24, 2021

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18246 (comment) was created by @agrawroh.

see: more, trace.

mattklein123
mattklein123 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please don't forget to revert the not-implemented hide changes in your other PR.

@mattklein123 mattklein123 merged commit 01b90ef into envoyproxy:main Sep 24, 2021
@agrawroh
Copy link
Copy Markdown
Member Author

agrawroh commented Sep 24, 2021

Thanks, please don't forget to revert the not-implemented hide changes in your other PR.

Thanks, @mattklein123! Yes, I'll revert the not-implemented hide changes and will address all the remaining comments.

soulxu pushed a commit to soulxu/envoy that referenced this pull request Oct 16, 2021
@agrawroh @soulxu
proto: add a new field called append_action in the HeaderValueOption (e…
6100e36 
…nvoyproxy#18246)

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
This was referenced Aug 16, 2022
Closed
Merged
htuch pushed a commit that referenced this pull request Aug 26, 2022
route: implementation of HeaderAppendAction (#22723)
5183dbf 
The HeaderAppendAction was added in the #18246. But the implementation never done. This PR try to complete this feature.

Further work of #18246. To close #22713.

Risk Level: Low.
Testing: Unit Test.

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
@coderabbitai coderabbitai bot mentioned this pull request Mar 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agrawroh @mattklein123 @adisuissa