kafka: fix integration test#17764
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Aug 19, 2021
Merged
Conversation
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-broker-intttest
branch
from
2af7d04 to
9cf8485
Compare
Contributor
Author
|
The release builds invoke the int test and pass, e.g. https://github.com/envoyproxy/envoy/runs/3365728636 : |
Contributor
Author
|
/assign @mattklein123 |
adamkotwasinski
commented
Aug 19, 2021
| flaky = True, | ||
| python_version = "PY3", | ||
| srcs_version = "PY3", | ||
| tags = ["manual"], |
Contributor
Author
There was a problem hiding this comment.
Given that Kafka has moved to contrib, why not give this a try, so far it appears to be stable.
In the worst case we'd go back to manual mode (and we're still keeping flaky just in case of slow machines, but the default of moderate = 5 minutes should be a good first idea).
mattklein123
approved these changes
Aug 19, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Sure happy to give it a shot, thanks.
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 19, 2021
* main: Fix for fuzz tests failing due to invalid corpus paths (envoyproxy#17767) kafka: fix integration test (envoyproxy#17764) Fix typo in cluster.proto (envoyproxy#17755) cluster manager: add drainConnections() API (envoyproxy#17747) kafka broker filter: move to contrib (envoyproxy#17750) quiche: switch external dependency to github (envoyproxy#17732) quiche: implement stream idle timeout in codec (envoyproxy#17674) Update c-ares to 1.17.2 (envoyproxy#17704) Fix dns resolve fuzz bug (envoyproxy#17107) Remove members that shadow members of the base class (envoyproxy#17713) thrift proxy: missing parts from the previous PR (envoyproxy#17668) thrift-proxy: cleanup ConnectionManager::ActiveRpc (envoyproxy#17734) listener: extra warning for deprecated use_proxy_proto field (envoyproxy#17736) kafka: add support for metadata request in mesh-filter (envoyproxy#17597) upstream: add all host map to priority set for fast host searching (envoyproxy#17290) Remove the support for `hidden_envoy_deprecated_per_filter_config` (envoyproxy#17725) tls: SDS support for private key providers (envoyproxy#16737) bazel: update rules_foreign_cc (envoyproxy#17445) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: fix integration test
Additional Description: fix broker integration test (it was referencing the normal binary) + make integration test run automatic (as it's now in contrib/)
FWIW inttest duration:
Mac i7-7820HQ + 8GB ram -> 78 seconds
Ubuntu i5-9400? + 8GB ram -> 36 seconds
CI -> 43s
Risk Level: Low
Testing: Integration tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A