kafka: add support for metadata request in mesh-filter#17597
Merged
mattklein123 merged 6 commits intoenvoyproxy:mainfrom Aug 17, 2021
Merged
kafka: add support for metadata request in mesh-filter#17597mattklein123 merged 6 commits intoenvoyproxy:mainfrom
mattklein123 merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/assign @mattklein123 |
adamkotwasinski
commented
Aug 16, 2021
| * Impl note: current matching from topic to cluster is based on prefix matching but more complex | ||
| * rules could be added. | ||
| */ | ||
| class UpstreamKafkaConfiguration { |
Contributor
Author
There was a problem hiding this comment.
Instances of this object will come from parsing config https://github.com/envoyproxy/envoy/pull/11936/files#diff-61bfe914c466f4da651a8940ca523c8517e792d0d498f606517c8f3ae9e06148R18
(the constructor call in https://github.com/envoyproxy/envoy/pull/11936/files#diff-925e5a6d6596e3c3dfe8145c80fa2c6ba955068b2c0a911351fa1cd911eda77eR19)
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
mattklein123
approved these changes
Aug 17, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Skim merging pending move to contrib.
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 19, 2021
* main: Fix for fuzz tests failing due to invalid corpus paths (envoyproxy#17767) kafka: fix integration test (envoyproxy#17764) Fix typo in cluster.proto (envoyproxy#17755) cluster manager: add drainConnections() API (envoyproxy#17747) kafka broker filter: move to contrib (envoyproxy#17750) quiche: switch external dependency to github (envoyproxy#17732) quiche: implement stream idle timeout in codec (envoyproxy#17674) Update c-ares to 1.17.2 (envoyproxy#17704) Fix dns resolve fuzz bug (envoyproxy#17107) Remove members that shadow members of the base class (envoyproxy#17713) thrift proxy: missing parts from the previous PR (envoyproxy#17668) thrift-proxy: cleanup ConnectionManager::ActiveRpc (envoyproxy#17734) listener: extra warning for deprecated use_proxy_proto field (envoyproxy#17736) kafka: add support for metadata request in mesh-filter (envoyproxy#17597) upstream: add all host map to priority set for fast host searching (envoyproxy#17290) Remove the support for `hidden_envoy_deprecated_per_filter_config` (envoyproxy#17725) tls: SDS support for private key providers (envoyproxy#16737) bazel: update rules_foreign_cc (envoyproxy#17445) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: add support for metadata request in mesh-filter
Additional Description: Add another request handler - metadata requests are used by Kafka clients to figure out where Kafka servers actually reside (first client connects to any server, sends metadata asking
who owns partitions x y zand then connects there). Given that we want Envoy to act as Kafka server (as we want whole traffic to pass thru it), we need to pretend that we are Kafka server - this is handled inMetadataRequestHolder::computeAnswer.Risk Level: Low
Testing: unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A