Skip to content

Remove the support for hidden_envoy_deprecated_per_filter_config#17725

Merged
htuch merged 1 commit intoenvoyproxy:mainfrom
tyxia:per_filter_config
Aug 17, 2021
Merged

Remove the support for hidden_envoy_deprecated_per_filter_config#17725
htuch merged 1 commit intoenvoyproxy:mainfrom
tyxia:per_filter_config

Conversation

@tyxia
Copy link
Member

@tyxia tyxia commented Aug 16, 2021

  • Update the constructor of PerFilterConfigs class
  • Remove the deprecated tests that are using per_filter_config field.

Signed-off-by: Tianyu Xia tyxia@google.com

Risk Level: LOW
Testing: CI

Signed-off-by: Tianyu Xia <tyxia@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #17725 was opened by tyxia.

see: more, trace.

@tyxia tyxia force-pushed the per_filter_config branch from f33b211 to c3dc684 Compare August 16, 2021 03:32
@tyxia tyxia marked this pull request as ready for review August 16, 2021 12:31
@tyxia
Copy link
Member Author

tyxia commented Aug 16, 2021

/assign @htuch
PTAL. Thanks!

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 1acf02f into envoyproxy:main Aug 17, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Aug 19, 2021
* main:
  Fix for fuzz tests failing due to invalid corpus paths (envoyproxy#17767)
  kafka: fix integration test (envoyproxy#17764)
  Fix typo in cluster.proto (envoyproxy#17755)
  cluster manager: add drainConnections() API (envoyproxy#17747)
  kafka broker filter: move to contrib (envoyproxy#17750)
  quiche: switch external dependency to github (envoyproxy#17732)
  quiche: implement stream idle timeout in codec (envoyproxy#17674)
  Update c-ares to 1.17.2 (envoyproxy#17704)
  Fix dns resolve fuzz bug (envoyproxy#17107)
  Remove members that shadow members of the base class (envoyproxy#17713)
  thrift proxy: missing parts from the previous PR (envoyproxy#17668)
  thrift-proxy: cleanup ConnectionManager::ActiveRpc (envoyproxy#17734)
  listener: extra warning for deprecated use_proxy_proto field (envoyproxy#17736)
  kafka: add support for metadata request in mesh-filter (envoyproxy#17597)
  upstream: add all host map to priority set for fast host searching (envoyproxy#17290)
  Remove the support for `hidden_envoy_deprecated_per_filter_config` (envoyproxy#17725)
  tls: SDS support for private key providers (envoyproxy#16737)
  bazel: update rules_foreign_cc (envoyproxy#17445)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@tyxia tyxia deleted the per_filter_config branch August 23, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants