Skip to content

thrift proxy: missing parts from the previous PR#17668

Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom
rgs1:thrift-proxy-shadowing-stat-plus-cleanup
Aug 17, 2021
Merged

thrift proxy: missing parts from the previous PR#17668
mattklein123 merged 4 commits intoenvoyproxy:mainfrom
rgs1:thrift-proxy-shadowing-stat-plus-cleanup

Conversation

@rgs1
Copy link
Member

@rgs1 rgs1 commented Aug 10, 2021

These are leftovers from the previous PR:

  • adds a counter for shadow requests that failed to be created
  • cleanup part of UpstreamRequest's interface

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

These are leftovers from the previous PR:

* adds a counter for shadow requests that failed to be created
* cleanup part of UpstreamRequest's interface

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@rgs1 rgs1 requested a review from zuercher as a code owner August 10, 2021 23:20
@rgs1
Copy link
Member Author

rgs1 commented Aug 11, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #17668 (comment) was created by @rgs1.

see: more, trace.

Raul Gutierrez Segales added 3 commits August 11, 2021 08:17
Dot
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattklein123 mattklein123 merged commit 49f7a96 into envoyproxy:main Aug 17, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Aug 19, 2021
* main:
  Fix for fuzz tests failing due to invalid corpus paths (envoyproxy#17767)
  kafka: fix integration test (envoyproxy#17764)
  Fix typo in cluster.proto (envoyproxy#17755)
  cluster manager: add drainConnections() API (envoyproxy#17747)
  kafka broker filter: move to contrib (envoyproxy#17750)
  quiche: switch external dependency to github (envoyproxy#17732)
  quiche: implement stream idle timeout in codec (envoyproxy#17674)
  Update c-ares to 1.17.2 (envoyproxy#17704)
  Fix dns resolve fuzz bug (envoyproxy#17107)
  Remove members that shadow members of the base class (envoyproxy#17713)
  thrift proxy: missing parts from the previous PR (envoyproxy#17668)
  thrift-proxy: cleanup ConnectionManager::ActiveRpc (envoyproxy#17734)
  listener: extra warning for deprecated use_proxy_proto field (envoyproxy#17736)
  kafka: add support for metadata request in mesh-filter (envoyproxy#17597)
  upstream: add all host map to priority set for fast host searching (envoyproxy#17290)
  Remove the support for `hidden_envoy_deprecated_per_filter_config` (envoyproxy#17725)
  tls: SDS support for private key providers (envoyproxy#16737)
  bazel: update rules_foreign_cc (envoyproxy#17445)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants