cluster manager: add drainConnections() API#17747
Merged
mattklein123 merged 1 commit intomainfrom Aug 18, 2021
Merged
Conversation
This will allow Envoy Mobile to force drain all cluster connection pool connections on network change, foregrounding after a long background, etc. Signed-off-by: Matt Klein <mklein@lyft.com>
goaway
approved these changes
Aug 18, 2021
Contributor
goaway
left a comment
goaway
left a comment
There was a problem hiding this comment.
From the Envoy Mobile perspective this looks great. String-based lookup is especially helpful, so we don't have to track Cluster references.
Thanks @mattklein123!
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 19, 2021
* main: Fix for fuzz tests failing due to invalid corpus paths (envoyproxy#17767) kafka: fix integration test (envoyproxy#17764) Fix typo in cluster.proto (envoyproxy#17755) cluster manager: add drainConnections() API (envoyproxy#17747) kafka broker filter: move to contrib (envoyproxy#17750) quiche: switch external dependency to github (envoyproxy#17732) quiche: implement stream idle timeout in codec (envoyproxy#17674) Update c-ares to 1.17.2 (envoyproxy#17704) Fix dns resolve fuzz bug (envoyproxy#17107) Remove members that shadow members of the base class (envoyproxy#17713) thrift proxy: missing parts from the previous PR (envoyproxy#17668) thrift-proxy: cleanup ConnectionManager::ActiveRpc (envoyproxy#17734) listener: extra warning for deprecated use_proxy_proto field (envoyproxy#17736) kafka: add support for metadata request in mesh-filter (envoyproxy#17597) upstream: add all host map to priority set for fast host searching (envoyproxy#17290) Remove the support for `hidden_envoy_deprecated_per_filter_config` (envoyproxy#17725) tls: SDS support for private key providers (envoyproxy#16737) bazel: update rules_foreign_cc (envoyproxy#17445) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
junr03
added a commit
that referenced
this pull request
Aug 19, 2021
Commit Message: cluster manager - overload drainConnections Additional Description: expands on #17747 with an overloaded method that drains all conn pools for all clusters in the cluster manager. Risk Level: low - new API Testing: integration test Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow Envoy Mobile to force drain all cluster connection pool
connections on network change, foregrounding after a long background,
etc.
Risk Level: Low
Testing: New integration test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A