Skip to content

ci(ui-e2e-gate): trigger on all of packages/ui/src — fixture runners bundle the whole tree - #11628

Merged
lalalune merged 1 commit into
developfrom
ci/widen-ui-e2e-gate-paths
Jul 2, 2026
Merged

ci(ui-e2e-gate): trigger on all of packages/ui/src — fixture runners bundle the whole tree#11628
lalalune merged 1 commit into
developfrom
ci/widen-ui-e2e-gate-paths

Conversation

@lalalune

@lalalune lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member

Why

The pre-#11271 ui-fixture-e2e.yml (superseded; its restore PR #11563 was closed) triggered on all of packages/ui/src/**. The current ui-e2e-gate.yml — which has carried all 14 fixture-runner legs since 19b40d1 — triggers only on an enumerated subset (components/shell, components/pages, components/chat/widgets, components/views, agent-surface, state, voice, testing, hooks).

Gap: changes under e.g. packages/ui/src/cloud/**, components/settings/**, bridge/**, components/composites/** skip the gate entirely, even though the bundled fixture runners esbuild-bundle from the full source tree — a regression in a shared component reachable from any runner can land unguarded. This carries the only useful delta from superseded #11563.

Change

Replace the enumerated packages/ui/src/* entries with a single packages/ui/src/** in both the pull_request and push paths lists. Kept unchanged: packages/ui/package.json, all packages/agent/* server-module paths (proactive-suggestions e2e), and the workflow self-path. Net: 4 insertions, 18 deletions, one file.

Verification

  • actionlint .github/workflows/ui-e2e-gate.yml → clean (0 findings).
  • Ratchet bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts: does not assert on the trigger paths list (it checks runner→script→workflow wiring), so no test update needed. It currently fails 1/1 on pristine origin/develop and identically with this change (verified both ways): two runners added by the cloud-ui PRs (feat(cloud-ui): org credentials tab + connect-link invite flow (#11332) #11488 org-credentials, frontend-hosting Cloud apps platform review: make frontend/backend hosting, domains, analytics, SEO, ads & content-gen general for all users #10690 work) — packages/ui/src/cloud/organization/__e2e__/run-credentials-e2e.mjs and packages/ui/src/cloud/applications/__e2e__/run-frontend-hosting-e2e.mjs — have no packages/ui package.json script. Pre-existing on develop, orthogonal to this diff (which touches only workflow trigger paths); those runners' dirs weren't even in the old trigger list, which is exactly the gap this PR closes. Wiring them needs its own PR (scripts + legs + running the runners).
  • Superset check: every removed glob is under packages/ui/src/** — no path that triggered before stops triggering.

Refs #11419

🤖 Generated with Claude Code

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a3ddeca6-4169-4f8a-8454-4163c9ebffe6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/widen-ui-e2e-gate-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…bundle the whole tree

The pre-#11271 ui-fixture-e2e.yml triggered on all of packages/ui/src/**;
ui-e2e-gate.yml (which carries all 14 fixture-runner legs since 19b40d1)
only triggered on an enumerated subset. Changes under e.g.
packages/ui/src/cloud/**, components/settings/**, bridge/**, or
components/composites/** skipped the gate entirely, even though the
runners esbuild-bundle from the full source tree — a regression in a
shared component reachable from any runner could land unguarded.

Replace the enumerated packages/ui/src/* entries with packages/ui/src/**
in both the pull_request and push paths lists. The packages/ui
package.json line, the packages/agent server-module lines, and the
workflow self-path are unchanged.

Refs #11419

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lalalune

lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Same-account review note, not an approval.

No findings. The change is a true trigger superset for the UI source paths: both pull_request.paths and push.paths replace the nine old packages/ui/src/... entries with packages/ui/src/**, while the packages/ui/package.json, proactive-suggestions agent paths, and workflow self-path stay unchanged.

Local Windows validation:

  • gh pr diff 11628 --name-only and refreshed git diff --name-only origin/develop...review/pr-11628 both show only .github/workflows/ui-e2e-gate.yml.
  • git diff --check origin/develop...review/pr-11628 -> clean.
  • YAML parse of review/pr-11628:.github/workflows/ui-e2e-gate.yml succeeds; parsed pull_request.paths count is 7 and push.paths count is 6.
  • Programmatic superset check against refreshed origin/develop: old UI PR path count 9, old UI push path count 9, both covered by packages/ui/src/**; non-UI path lists unchanged for PR and push.

Caveat: actionlint/Go is not installed on this Windows box and bunx actionlint has no runnable npm executable, so I could not locally rerun the exact actionlint command from the PR body. CI remains the source of truth for that lane.

@lalalune
lalalune force-pushed the ci/widen-ui-e2e-gate-paths branch from 5c59314 to 570118c Compare July 2, 2026 22:13
@lalalune

lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Validation after rebase onto current origin/develop:

  • actionlint .github/workflows/ui-e2e-gate.yml — clean.
  • git diff --check origin/develop...HEAD && git diff --check — clean.
  • Inspected the committed workflow diff: only the enumerated packages/ui/src trigger globs were collapsed to packages/ui/src/** in pull_request and push. package.json, agent server paths, and workflow self-path stayed intact.
  • Superset check over the diff: added packages/ui/src/** in both trigger blocks; 18 removed packages/ui/src/... globs are all covered by that broader glob.

No approval from me because this PR is self-authored under lalalune.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions github-actions Bot added the ci label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants