ci(ui-e2e-gate): trigger on all of packages/ui/src — fixture runners bundle the whole tree - #11628
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…bundle the whole tree The pre-#11271 ui-fixture-e2e.yml triggered on all of packages/ui/src/**; ui-e2e-gate.yml (which carries all 14 fixture-runner legs since 19b40d1) only triggered on an enumerated subset. Changes under e.g. packages/ui/src/cloud/**, components/settings/**, bridge/**, or components/composites/** skipped the gate entirely, even though the runners esbuild-bundle from the full source tree — a regression in a shared component reachable from any runner could land unguarded. Replace the enumerated packages/ui/src/* entries with packages/ui/src/** in both the pull_request and push paths lists. The packages/ui package.json line, the packages/agent server-module lines, and the workflow self-path are unchanged. Refs #11419 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Same-account review note, not an approval. No findings. The change is a true trigger superset for the UI source paths: both Local Windows validation:
Caveat: |
5c59314 to
570118c
Compare
|
Validation after rebase onto current origin/develop:
No approval from me because this PR is self-authored under lalalune. |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Why
The pre-#11271
ui-fixture-e2e.yml(superseded; its restore PR #11563 was closed) triggered on all ofpackages/ui/src/**. The currentui-e2e-gate.yml— which has carried all 14 fixture-runner legs since 19b40d1 — triggers only on an enumerated subset (components/shell,components/pages,components/chat/widgets,components/views,agent-surface,state,voice,testing,hooks).Gap: changes under e.g.
packages/ui/src/cloud/**,components/settings/**,bridge/**,components/composites/**skip the gate entirely, even though the bundled fixture runners esbuild-bundle from the full source tree — a regression in a shared component reachable from any runner can land unguarded. This carries the only useful delta from superseded #11563.Change
Replace the enumerated
packages/ui/src/*entries with a singlepackages/ui/src/**in both thepull_requestandpushpaths lists. Kept unchanged:packages/ui/package.json, allpackages/agent/*server-module paths (proactive-suggestions e2e), and the workflow self-path. Net: 4 insertions, 18 deletions, one file.Verification
actionlint .github/workflows/ui-e2e-gate.yml→ clean (0 findings).bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts: does not assert on the trigger paths list (it checks runner→script→workflow wiring), so no test update needed. It currently fails 1/1 on pristine origin/develop and identically with this change (verified both ways): two runners added by the cloud-ui PRs (feat(cloud-ui): org credentials tab + connect-link invite flow (#11332) #11488 org-credentials, frontend-hosting Cloud apps platform review: make frontend/backend hosting, domains, analytics, SEO, ads & content-gen general for all users #10690 work) —packages/ui/src/cloud/organization/__e2e__/run-credentials-e2e.mjsandpackages/ui/src/cloud/applications/__e2e__/run-frontend-hosting-e2e.mjs— have nopackages/uipackage.json script. Pre-existing on develop, orthogonal to this diff (which touches only workflow trigger paths); those runners' dirs weren't even in the old trigger list, which is exactly the gap this PR closes. Wiring them needs its own PR (scripts + legs + running the runners).packages/ui/src/**— no path that triggered before stops triggering.Refs #11419
🤖 Generated with Claude Code