Skip to content

ci(ui-e2e-gate): wire the orphaned slop-removal cloud e2e runner (ratchet red on develop) - #11702

Merged
lalalune merged 1 commit into
developfrom
ci/wire-slop-removal-e2e-runner
Jul 3, 2026
Merged

ci(ui-e2e-gate): wire the orphaned slop-removal cloud e2e runner (ratchet red on develop)#11702
lalalune merged 1 commit into
developfrom
ci/wire-slop-removal-e2e-runner

Conversation

@lalalune

@lalalune lalalune commented Jul 3, 2026

Copy link
Copy Markdown
Member

Found during #11628 verification (follow-up to #11646).

Problem

The packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts ratchet is red on develop again. #11646 (merged 2026-07-02 23:05:30Z) wired the credentials + frontend-hosting runners, but #11657 (merged 2026-07-02 23:04:19Z — one minute earlier, in-flight at the same time) added a third runner, packages/ui/src/cloud/__e2e__/run-slop-removal-e2e.mjs, with no packages/ui package.json script and no CI leg:

packages/ui/src/cloud/__e2e__/run-slop-removal-e2e.mjs: no packages/ui package.json script references it — add one (or delete the runner)

Change (8 insertions, 2 files)

  • packages/ui/package.json: add test:slop-removal-e2e (same bun run --cwd ../.. <runner> convention as the neighboring scripts).
  • .github/workflows/ui-e2e-gate.yml: add a "Cloud settings surface (slop-removal) e2e" leg after the credentials leg, and add output-slop-removal to the artifact upload paths.

Verification (all local, this branch on top of current develop)

Check Result
bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts 1 pass / 0 fail (was 0/1 on develop)
bun run --cwd packages/ui test:slop-removal-e2e (exact CI invocation) exit 0, ALL CHECKS PASSED, 30/30 ✓ assertions
bun run --cwd packages/ui test:credentials-e2e (re-validated #11646 leg) exit 0, ALL GREEN, 11/11 ✓ assertions
bun run --cwd packages/ui test:frontend-hosting-e2e (re-validated #11646 leg) exit 0, ALL GREEN, 7/7 ✓ assertions
actionlint .github/workflows/ui-e2e-gate.yml clean

Committed evidence outputs (output-slop-removal/, RESULT.json, walkthrough.webm) were regenerated locally by these runs and deliberately restored to HEAD to keep the diff to the 8-line wiring change; the checked-in evidence from #11657 remains canonical.

No other orphaned runners: the ratchet enumerates every run-*.mjs under packages/ui/src/**/__e2e__ and passes 1/1 with this change.

🤖 Generated with Claude Code

The ui-e2e-runner-coverage ratchet went red on develop again right after
#11646 merged: #11657 (cloud-surface unification, merged one minute earlier)
added packages/ui/src/cloud/__e2e__/run-slop-removal-e2e.mjs with no
packages/ui package.json script and no CI leg. Add test:slop-removal-e2e
and a matching ui-e2e-gate.yml leg + artifact upload path.

Runner verified green locally via the exact CI invocation
(bun run --cwd packages/ui test:slop-removal-e2e): 30/30 checks, exit 0.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fb30bcf0-aeab-4b56-b1b2-07fa67c93b59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/wire-slop-removal-e2e-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@lalalune
lalalune merged commit 9df77a4 into develop Jul 3, 2026
34 of 63 checks passed
@lalalune
lalalune deleted the ci/wire-slop-removal-e2e-runner branch July 3, 2026 00:08
@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants