Skip to content

ci(ui-e2e-gate): wire the warmup-eviction runner leg — ratchet red on develop again (#11698 landed script-only) - #11704

Merged
lalalune merged 1 commit into
developfrom
ci/wire-warmup-eviction-e2e-leg
Jul 3, 2026
Merged

lalalune merged 1 commit into
developfrom
ci/wire-warmup-eviction-e2e-leg

Conversation

@lalalune

@lalalune lalalune commented Jul 3, 2026

Copy link
Copy Markdown
Member

Found during #11628 verification — third strike in the same race. Follow-up to #11646 and #11702.

Problem

The packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts ratchet is red on develop again: #11698 (warm-up eviction fix, merged 2026-07-02 ~23:5xZ) added packages/ui/src/components/shell/__e2e__/run-warmup-eviction-e2e.mjs with a test:warmup-eviction-e2e package script but without any workflow leg:

packages/ui/src/components/shell/__e2e__/run-warmup-eviction-e2e.mjs: script "test:warmup-eviction-e2e" is not invoked by any .github/workflows/*.yml — wire a leg (ui-fixture-e2e.yml) or delete the runner with justification

Change (7 insertions, 1 file)

.github/workflows/ui-e2e-gate.yml: add a "Warm-up message eviction e2e" leg next to its shell-family siblings (after fused-wake), and add output-warmup-eviction to the artifact upload paths. The package script already exists on develop — no package.json change needed.

Verification (local, this branch = develop + this commit)

Check Result
bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts 1 pass / 0 fail (red on develop without this)
bun run --cwd packages/ui test:warmup-eviction-e2e (exact CI invocation) exit 0, PASS, 8/8 ✓ assertions (optimistic bubble survives reconcile, retryable failed turn, exactly-once delivery on Retry, no page errors)
actionlint .github/workflows/ui-e2e-gate.yml clean

Regenerated output-warmup-eviction/ evidence from the local run was restored to HEAD; the checked-in evidence from #11698 remains canonical.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4215e0ee-64ef-474e-be03-85e4582dd44e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/wire-warmup-eviction-e2e-leg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

…cript-only)

Develop moved again mid-fix: #11698 added run-warmup-eviction-e2e.mjs with a
packages/ui test:warmup-eviction-e2e script but no workflow leg, so the
ui-e2e-runner-coverage ratchet stayed red. Add the gate leg next to its shell
siblings + the artifact upload path.

Runner verified green locally via the exact CI invocation: 8/8 checks, exit 0.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lalalune
lalalune force-pushed the ci/wire-warmup-eviction-e2e-leg branch from 63af6be to 1426f9b Compare July 3, 2026 00:20

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@lalalune

lalalune commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

Rebased #11704 onto current develop 62002b1c755 and revalidated.

Local verification:

  • bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts -> 1 pass / 0 fail / 2 assertions
  • actionlint .github/workflows/ui-e2e-gate.yml -> clean
  • git diff --check origin/develop...HEAD and git diff --check -> clean
  • bun run --cwd packages/ui test:warmup-eviction-e2e -> PASS, 8/8 assertions:
    • optimistic user bubble renders on send
    • user bubble survives the warm-up 503 + reconcile reload
    • retryable failed assistant turn appears
    • failed turn explains message did not reach the agent
    • retry delivers exactly once
    • agent reply lands after retry
    • failed turn is reconciled away after persistence
    • no page errors

I opened the generated final screenshot (03-delivered-after-retry.png) and confirmed the user message remains and the retried agent reply is present. Regenerated output files were restored so this PR remains the intended one-file workflow change.

@lalalune
lalalune force-pushed the ci/wire-warmup-eviction-e2e-leg branch from 1426f9b to 094e3c9 Compare July 3, 2026 00:20

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@lalalune

lalalune commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

Validation after rebase onto origin/develop (62002b1c755):

  • Confirmed .github/workflows/ui-e2e-gate.yml invokes the existing packages/ui script test:warmup-eviction-e2e.
  • Confirmed artifact upload includes packages/ui/src/components/shell/__e2e__/output-warmup-eviction.
  • Ran the fixture and manually reviewed generated screenshots/logs: warm-up screen, retryable failed turn with surviving user bubble, and successful retry/reconciled final reply. The local run regenerated tracked output files, and I restored those side effects so the branch remains workflow-only.

Checks run:

  • bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts
  • actionlint .github/workflows/ui-e2e-gate.yml
  • git diff --check origin/develop...HEAD && git diff --check
  • bun run --cwd packages/ui test:warmup-eviction-e2e

No approval from me because this PR is self-authored by lalalune.

@lalalune
lalalune merged commit f334828 into develop Jul 3, 2026
28 of 38 checks passed
@lalalune
lalalune deleted the ci/wire-warmup-eviction-e2e-leg branch July 3, 2026 00:21
@github-actions github-actions Bot added the ci label Jul 3, 2026
@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants