ci(ui-e2e-gate): wire the warmup-eviction runner leg — ratchet red on develop again (#11698 landed script-only) - #11704
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
…cript-only) Develop moved again mid-fix: #11698 added run-warmup-eviction-e2e.mjs with a packages/ui test:warmup-eviction-e2e script but no workflow leg, so the ui-e2e-runner-coverage ratchet stayed red. Add the gate leg next to its shell siblings + the artifact upload path. Runner verified green locally via the exact CI invocation: 8/8 checks, exit 0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
63af6be to
1426f9b
Compare
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Rebased #11704 onto current Local verification:
I opened the generated final screenshot ( |
1426f9b to
094e3c9
Compare
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Validation after rebase onto
Checks run:
No approval from me because this PR is self-authored by lalalune. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Found during #11628 verification — third strike in the same race. Follow-up to #11646 and #11702.
Problem
The
packages/scripts/__tests__/ui-e2e-runner-coverage.test.tsratchet is red on develop again: #11698 (warm-up eviction fix, merged 2026-07-02 ~23:5xZ) addedpackages/ui/src/components/shell/__e2e__/run-warmup-eviction-e2e.mjswith atest:warmup-eviction-e2epackage script but without any workflow leg:Change (7 insertions, 1 file)
.github/workflows/ui-e2e-gate.yml: add a "Warm-up message eviction e2e" leg next to its shell-family siblings (after fused-wake), and addoutput-warmup-evictionto the artifact upload paths. The package script already exists on develop — no package.json change needed.Verification (local, this branch = develop + this commit)
bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.tsbun run --cwd packages/ui test:warmup-eviction-e2e(exact CI invocation)PASS, 8/8 ✓ assertions (optimistic bubble survives reconcile, retryable failed turn, exactly-once delivery on Retry, no page errors)actionlint .github/workflows/ui-e2e-gate.ymlRegenerated
output-warmup-eviction/evidence from the local run was restored to HEAD; the checked-in evidence from #11698 remains canonical.🤖 Generated with Claude Code