ci: restore ui-fixture-e2e.yml deleted by #11271's stale-base squash - #11563
ci: restore ui-fixture-e2e.yml deleted by #11271's stale-base squash#11563lalalune wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Verified the restore locally. The workflow file is byte-identical to the pre-clobber cec0509 version, current origin/develop does not contain .github/workflows/ui-fixture-e2e.yml, YAML parses cleanly with PyYAML, and actionlint .github/workflows/ui-fixture-e2e.yml passes from the PR worktree. Biome is not applicable here because this repo config ignores YAML workflow files. Remaining gate is pending CI plus an independent approval, since GitHub will not let the author account approve its own PR. |
Restores the UI Fixture E2E workflow (125 lines, byte-identical to the pre-#11271 state at 5b714c7^) that gated the ten packages/ui fixture e2e runners (agent-surface bridge, bottombar, ambient background, background/launcher/connectors pages, view lifecycle, ftu-home, orchestrator-accounts, fused-wake) on packages/ui changes. It was deleted wholesale by the #11271 squash and is the last of the five launch-critical workflow files named in the #11419 tracker without a restore (test.yml / scenario-pr.yml / kokoro-real-smoke.yml restored by 19b40d1; lifeops-quality-bench.yml restored by #11530). All ten 'test:*-e2e' scripts the workflow invokes verified present in packages/ui/package.json on current develop. Refs #11419 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ad9b5ca to
6a4e5da
Compare
|
Rebased onto origin/develop and pushed 6a4e5da. Local validation: actionlint .github/workflows/ui-fixture-e2e.yml passed; Ruby YAML parsing passed; all ten workflow commands exist in packages/ui/package.json; git diff --check is clean. I did not approve because this account authored the PR. Review note: the restore is intentionally byte-identical and therefore keeps BUN_VERSION: canary. That matches the pre-#11271 workflow, but it is worth a human reviewer explicitly accepting that in light of #11547's narrower cloud-lane Bun pin. |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Local verification result: this restore would be RED on develop, and the coverage it restores already exists in Ran all ten runners exactly as this workflow does (
Root cause of the 2 reds (workflow rot, not UI rot): Redundancy: develop commit Merging this PR as-is would add a duplicate 10-leg workflow that is deterministically red on 2 legs and doubles CI cost on every packages/ui PR. The only delta it would offer is the blanket 🤖 Generated with Claude Code |
Review: REQUEST CHANGES — the coverage this restores already landed on develop via
|
|
Closing as superseded by the current develop workflow coverage. The restored UI fixture jobs are already covered in |
|
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
2 participants
Refs #11419 (the #11271 regression tracker).
Restores
.github/workflows/ui-fixture-e2e.ymlbyte-identical to the pre-#11271 state (5b714c74e6^). This was the last of the five launch-critical workflow files named in the tracker without a restore:19b40d12aeThe workflow gates the ten
packages/uifixture e2e runners (agent-surface bridge, bottombar, chat-ambient, background, launcher, connectors, ftu-home, orchestrator-accounts, view-lifecycle, fused-wake) onpackages/uichanges — #9310 §3.16 coverage that has been silently absent since the squash.Verification
actionlint: clean.test:*-e2escripts the workflow invokes verified present inpackages/ui/package.jsonon current develop tip.🤖 Generated with Claude Code