ci(ui-e2e-gate): wire the two orphaned cloud e2e runners - #11646
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…s + frontend-hosting The ui-e2e-runner-coverage ratchet was red on develop: run-credentials-e2e.mjs (#11488 org credentials tab) and run-frontend-hosting-e2e.mjs (#10690/#11425 hosting work) landed with no packages/ui package.json script and no CI leg, so they could only run by hand. Add test:credentials-e2e and test:frontend-hosting-e2e scripts and matching ui-e2e-gate.yml legs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
efc06a9 to
31a00d3
Compare
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Fable-5 takeover re-verification (post-rebase onto develop
No code changes were needed — rebase only. Verdict: READY_TO_MERGE. 🤖 Generated with Claude Code |
|
Same-account review note (no independent approval from me). Local sparse validation on
No findings. I did not rerun the two long browser e2e flows locally in this pass; I treated the PR's recorded green runs plus the ratchet as the relevant review signal here. |
) The ui-e2e-runner-coverage ratchet went red on develop again right after #11646 merged: #11657 (cloud-surface unification, merged one minute earlier) added packages/ui/src/cloud/__e2e__/run-slop-removal-e2e.mjs with no packages/ui package.json script and no CI leg. Add test:slop-removal-e2e and a matching ui-e2e-gate.yml leg + artifact upload path. Runner verified green locally via the exact CI invocation (bun run --cwd packages/ui test:slop-removal-e2e): 30/30 checks, exit 0. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Summary
Fixes a develop-red:
packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts(the ratchet ensuring everypackages/ui __e2e__runner has apackage.jsonscript + CI leg) was FAILING 1/1 on pristineorigin/develop, found while verifying the #11628 CI-coverage sweep.Two runners landed with no wiring:
packages/ui/src/cloud/organization/__e2e__/run-credentials-e2e.mjs(feat(cloud-ui): org credentials tab + connect-link invite flow (#11332) #11488 org credentials tab)packages/ui/src/cloud/applications/__e2e__/run-frontend-hosting-e2e.mjs(Cloud apps platform review: make frontend/backend hosting, domains, analytics, SEO, ads & content-gen general for all users #10690 hosting work / feat(ui,app,plugins): UI/mobile gap burndown — slash-menu touch safety, spatial/tap-target gates, hosting UI, cloud-agent cold-boot, inbox port, lifecycle honesty (8 verified legs) #11425)Added
test:credentials-e2e/test:frontend-hosting-e2escripts topackages/ui/package.json, following the existingtest:<name>-e2econvention.Added matching legs to
.github/workflows/ui-e2e-gate.yml, after the existing runner legs, plus their output dirs to the artifact-upload path list. This workflow already triggers onpackages/ui/src/**(ci(ui-e2e-gate): trigger on all of packages/ui/src — fixture runners bundle the whole tree #11628), so no path-filter changes were needed.Local runner results (real headless-Chromium runs, real mock cloud stack — PGlite + Hono + live key-probe stub)
bun run --cwd packages/ui test:frontend-hosting-e2e→ ALL GREEN. Publish → v1 live → v2 live → rollback confirm → rolled-back-to-v1 → delete confirm → after-delete, desktop + mobile, plus the cloud-inactive (502) → retry-recovers assertion. Orange-accent / darker-orange-hover / no-blue aesthetic assertions all passed.bun run --cwd packages/ui test:credentials-e2e→ ALL GREEN. Empty state → contribute (probe FAIL then probe PASS) → masked list row → disable/enable toggle → invite & connect link → connect-link landing → remove-confirm → delete, desktop + mobile, with the same aesthetic assertions plus "plaintext key never appears in the DOM" and "server confirms pool is empty after remove".Neither runner needed any fix — both were fully working, just CI-orphaned.
Verification
bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts→ 1 pass / 0 fail (was failing on pristine develop before this change).actionlint .github/workflows/ui-e2e-gate.yml→ clean.Test plan
🤖 Generated with Claude Code