Skip to content

ci(ui-e2e-gate): wire the two orphaned cloud e2e runners - #11646

Merged
lalalune merged 1 commit into
developfrom
ci/wire-orphaned-ui-e2e-runners
Jul 2, 2026
Merged

ci(ui-e2e-gate): wire the two orphaned cloud e2e runners#11646
lalalune merged 1 commit into
developfrom
ci/wire-orphaned-ui-e2e-runners

Conversation

@lalalune

@lalalune lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

Fixes a develop-red: packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts (the ratchet ensuring every packages/ui __e2e__ runner has a package.json script + CI leg) was FAILING 1/1 on pristine origin/develop, found while verifying the #11628 CI-coverage sweep.

Two runners landed with no wiring:

Local runner results (real headless-Chromium runs, real mock cloud stack — PGlite + Hono + live key-probe stub)

  • bun run --cwd packages/ui test:frontend-hosting-e2eALL GREEN. Publish → v1 live → v2 live → rollback confirm → rolled-back-to-v1 → delete confirm → after-delete, desktop + mobile, plus the cloud-inactive (502) → retry-recovers assertion. Orange-accent / darker-orange-hover / no-blue aesthetic assertions all passed.
  • bun run --cwd packages/ui test:credentials-e2eALL GREEN. Empty state → contribute (probe FAIL then probe PASS) → masked list row → disable/enable toggle → invite & connect link → connect-link landing → remove-confirm → delete, desktop + mobile, with the same aesthetic assertions plus "plaintext key never appears in the DOM" and "server confirms pool is empty after remove".

Neither runner needed any fix — both were fully working, just CI-orphaned.

Verification

  • bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts → 1 pass / 0 fail (was failing on pristine develop before this change).
  • actionlint .github/workflows/ui-e2e-gate.yml → clean.

Test plan

  • Ratchet test passes locally
  • Both new runners executed locally end-to-end, ALL GREEN
  • actionlint clean on the modified workflow
  • CI (rarely completes per repo convention; this local run is the merge gate)

🤖 Generated with Claude Code

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 50699c9b-1ccd-4854-869d-ee925b96ec52

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/wire-orphaned-ui-e2e-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…s + frontend-hosting

The ui-e2e-runner-coverage ratchet was red on develop: run-credentials-e2e.mjs
(#11488 org credentials tab) and run-frontend-hosting-e2e.mjs (#10690/#11425
hosting work) landed with no packages/ui package.json script and no CI leg,
so they could only run by hand. Add test:credentials-e2e and
test:frontend-hosting-e2e scripts and matching ui-e2e-gate.yml legs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lalalune
lalalune force-pushed the ci/wire-orphaned-ui-e2e-runners branch from efc06a9 to 31a00d3 Compare July 2, 2026 22:41

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@lalalune

lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Fable-5 takeover re-verification (post-rebase onto develop 7acf5a4a1a, new head 31a00d358b):

  • Premise re-confirmed: on pristine origin/develop, both runner files exist but have 0 references in packages/ui/package.json and 0 in any .github/workflows/*.yml → ratchet red 1/1.
  • Both runners re-run end-to-end by the verifier (headless Chromium, real mock cloud stack):
    • test:frontend-hosting-e2eALL GREEN (13 screenshots incl. 502 cloud-inactive → retry-recovers)
    • test:credentials-e2eALL GREEN (14 screenshots incl. probe-fail 401 inline, masked-key/no-plaintext-in-DOM, invite-link-carries-no-key-material, empty-pool-after-remove)
  • bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts1 pass / 0 fail on the rebased head.
  • actionlint .github/workflows/ui-e2e-gate.yml → clean.
  • Legs sit after the ensure-shared-i18n-data + Playwright-install steps; artifact-upload paths match the runners' real outDirs (output-frontend-hosting, output-credentials).

No code changes were needed — rebase only. Verdict: READY_TO_MERGE.

🤖 Generated with Claude Code

@lalalune

lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Same-account review note (no independent approval from me).

Local sparse validation on 31a00d358b:

  • bun test packages/scripts/__tests__/ui-e2e-runner-coverage.test.ts -> 1 pass / 0 fail.
  • git diff --check origin/develop...HEAD -> clean.
  • Parsed .github/workflows/ui-e2e-gate.yml as UTF-8 YAML and verified the ui-fixture-e2e job has steps for:
    • bun run --cwd packages/ui test:frontend-hosting-e2e
    • bun run --cwd packages/ui test:credentials-e2e
  • Verified packages/ui/package.json scripts point at the two existing runners:
    • packages/ui/src/cloud/applications/__e2e__/run-frontend-hosting-e2e.mjs
    • packages/ui/src/cloud/organization/__e2e__/run-credentials-e2e.mjs
  • Verified artifact upload includes the two new output directories.

No findings. I did not rerun the two long browser e2e flows locally in this pass; I treated the PR's recorded green runs plus the ratchet as the relevant review signal here.

@lalalune
lalalune merged commit 3686fbd into develop Jul 2, 2026
33 of 64 checks passed
@lalalune
lalalune deleted the ci/wire-orphaned-ui-e2e-runners branch July 2, 2026 23:05
lalalune added a commit that referenced this pull request Jul 3, 2026
)

The ui-e2e-runner-coverage ratchet went red on develop again right after
#11646 merged: #11657 (cloud-surface unification, merged one minute earlier)
added packages/ui/src/cloud/__e2e__/run-slop-removal-e2e.mjs with no
packages/ui package.json script and no CI leg. Add test:slop-removal-e2e
and a matching ui-e2e-gate.yml leg + artifact upload path.

Runner verified green locally via the exact CI invocation
(bun run --cwd packages/ui test:slop-removal-e2e): 30/30 checks, exit 0.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants