-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTP 24 compatibility: extract line number from location tuple #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcrossland
changed the title
build_result/4 extract line number from tuple
OTP-24 compatibility: Extract line number from location tuple
Mar 3, 2021
tcrossland
changed the title
OTP-24 compatibility: Extract line number from location tuple
OTP 24 compatibility: extract line number from location tuple
Mar 3, 2021
lukaszsamson
reviewed
Mar 3, 2021
apps/language_server/lib/language_server/providers/workspace_symbols.ex
Outdated
Show resolved
Hide resolved
lukaszsamson
approved these changes
Mar 4, 2021
Similar changes are needed in elixir_sense |
axelson
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
axelson
added a commit
to axelson/elixir-ls
that referenced
this pull request
Mar 5, 2021
axelson
added a commit
that referenced
this pull request
Mar 28, 2021
* Add changelog test to verify that the changelog is correctly linked * Update changelog * Add #497 * Specify that the fuzzy completion is only for functions * Fix formatting * update changelog for #505 * Update changelog for #501, #473, and #504 * Update changelog for #507 and vscode #176 * Update changelog for #511 * Update changelog for #492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTP 24 includes changes in the Erlang compiler to include column number information. Column information obtained from the chunk data is not currently handled by
WorkspaceSymbols.build_result/4
and provokes anArithmeticError
exception as decribed in #503:elixir-ls/apps/language_server/lib/language_server/providers/workspace_symbols.ex
Lines 480 to 490 in b9f55cc
This PR changes
build_result/4
to extract the line number when a tuple{line, column}
is read from the chunk data.