Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope expandMacro command to ElixirLS server instance #505

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

tcrossland
Copy link
Contributor

#498 introduces an issue with multi-project workspaces in VSCode. Previously, an ElixirLS process would be started for each open project. Now, after the first ElixirLS process is started, subsequent launches fail to start with the following warnings:

  • Couldn't start client ElixirLS
  • command 'expandMacro' already exists

See also: haskell/haskell-ide-engine#629

@lukaszsamson
Copy link
Collaborator

lukaszsamson commented Mar 4, 2021

Thanks

@lukaszsamson lukaszsamson merged commit 9aac258 into elixir-lsp:master Mar 4, 2021
@tcrossland tcrossland deleted the fix/expandmacro branch March 4, 2021 08:49
axelson added a commit to axelson/elixir-ls that referenced this pull request Mar 5, 2021
axelson added a commit to axelson/elixir-ls that referenced this pull request Mar 5, 2021
lukaszsamson pushed a commit that referenced this pull request Mar 6, 2021
* Ensure that all commands include the server instance id

Will help prevent needing to fix bugs like:
#505

* Fix issue in the test
axelson added a commit that referenced this pull request Mar 28, 2021
* Add changelog test to verify that the changelog is correctly linked

* Update changelog

* Add #497

* Specify that the fuzzy completion is only for functions

* Fix formatting

* update changelog for #505

* Update changelog for #501, #473, and #504

* Update changelog for #507 and vscode #176

* Update changelog for #511

* Update changelog for #492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants