Make compiler report column as well as line number #2664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My own patches included documentation. :P |
This was referenced Dec 18, 2020
|
Since we've made many updates and also rebased the branch, we've decided to create a new PR. See also #3006. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds column number support for the compiler, for passes before the transformation to Core Erlang.
There is one problem with the warnings_SUITE latin1_fallback test, which appears to be nondeterministic. The reported column in the invalid_unicode error message (apparently from the io server) is sometimes 24, sometimes 25, and sometimes 1.