Make wrapper script more robust... more robustly #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lukaszsamson
reviewed
Feb 3, 2021
|
We would need a similar change in debugger.sh |
|
Hmmm... Are you still interested in this change? #467 offers an alternative to solve this issue. The specific use-case of using a symlink (as addressed in this PR) still wouldn't work but alternatively the |
|
@jtrees I think it would be nice to include, although I'm not sure how common using a symlink like this is. But I would generally expect a symlink to work so it would be nice to support it. |
This makes a setup possible in which a symlink points to the file (e.g. /usr/local/bin/elixir-ls -> /opt/elixir-ls/language_server.sh). It's a rehash of a previous commit that was reverted since it broke setups where the language server was installed in a path containing spaces (e.g. /opt/Elixir Language Server/). This variant takes that possibility into account.
I'm not really sure what could lead this to happen. Maybe some weird directory permissions with the read bit on and the exec bit off... Still good to be careful though. Co-authored-by: Łukasz Samson <[email protected]>
lukaszsamson
approved these changes
Feb 24, 2021
axelson
approved these changes
Mar 5, 2021
axelson
added a commit
to axelson/elixir-ls
that referenced
this pull request
Mar 5, 2021
axelson
added a commit
that referenced
this pull request
Mar 28, 2021
* Add changelog test to verify that the changelog is correctly linked * Update changelog * Add #497 * Specify that the fuzzy completion is only for functions * Fix formatting * update changelog for #505 * Update changelog for #501, #473, and #504 * Update changelog for #507 and vscode #176 * Update changelog for #511 * Update changelog for #492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a setup possible in which a symlink points to the file (e.g. /usr/local/bin/elixir-ls -> /opt/elixir-ls/language_server.sh).
It's a rehash of a previous PR (#445) that was reverted since it broke setups where the language server was installed in a path containing spaces (e.g. /opt/Elixir Language Server/). This variant takes that possibility into account.
Hopefully, this fixes #470.