Snippet variants with n-1 placeholders to use after pipe #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple implementation based on harcoded variants for the most common use-cases: case, unless and if.
lukaszsamson
approved these changes
Mar 2, 2021
axelson
approved these changes
Mar 5, 2021
axelson
added a commit
to axelson/elixir-ls
that referenced
this pull request
Mar 5, 2021
axelson
added a commit
that referenced
this pull request
Mar 28, 2021
* Add changelog test to verify that the changelog is correctly linked * Update changelog * Add #497 * Specify that the fuzzy completion is only for functions * Fix formatting * update changelog for #505 * Update changelog for #501, #473, and #504 * Update changelog for #507 and vscode #176 * Update changelog for #511 * Update changelog for #492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple implementation based on harcoded variants for the most common use-cases: case, unless and if.
I didn't want overcomplicate it by trying to automatically rewrite snippets into a n-1 version,
if,caseandunlessby themselves should cover the vast majority of real uses cases anyway, I think it's quite rare to pipe stuff todef*& friends.Before:
elixir-ls-before.mp4
After:
elixir-ls-after.mp4
In non-pipe context, the snippets work as before.