Skip to content

Doc: Add geoip database API to node stats#13019

Merged
karenzone merged 2 commits intoelastic:masterfrom
karenzone:geoip-api
Jun 24, 2021
Merged

Doc: Add geoip database API to node stats#13019
karenzone merged 2 commits intoelastic:masterfrom
karenzone:geoip-api

Conversation

@karenzone
Copy link
Contributor

@karenzone karenzone commented Jun 22, 2021

PREVIEW: https://logstash_13019.docs-preview.app.elstc.co/guide/en/logstash/master/node-stats-api.html

Release notes

[rn:skip]

What does this PR do?

Adds geoip database API to node stats documentation with reference back to Geoip filter plugin docs.
Updates topic to current documentation standards for tagging and capitalization.

Related: logstash-plugins/logstash-filter-geoip#187

ToDo:
Add deep link to Database Metrics section after logstash-plugins/logstash-filter-geoip#187 has been merged and published.


[source,js]
--------------------------------------------------
curl -XGET 'localhost:9600/_node/stats/geoip?pretty'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have decided to change the metrics holder from geoip to geoip_download_manager. So the API is
curl -XGET 'localhost:9600/_node/stats/geoip_download_manager?pretty'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the decision is here #13004 (comment)

Gets runtime stats about config reload successes and failures.
<<os-stats,`os`>>::
Gets runtime stats about cgroups when Logstash is running in a container.
<<geoip-database-stats,`geoip`>>::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this as well
<<geoip-database-stats,geoip_download_manager>>::

@kaisecheng
Copy link
Contributor

@karenzone Thanks for updating the doc for geoip. The plugin 7.2.2 is released. You can start your ToDo. Sorry for the last minute change of the API geoip -> geoip_download_manager. Other than that LGTM

@karenzone karenzone requested a review from kaisecheng June 23, 2021 19:40
@karenzone
Copy link
Contributor Author

@kaisecheng, thanks for your comments. I think we're ready for final review. 🤞

Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💟

@karenzone karenzone merged commit a31a7a4 into elastic:master Jun 24, 2021
@karenzone karenzone deleted the geoip-api branch June 24, 2021 12:38
karenzone added a commit to karenzone/logstash that referenced this pull request Jun 24, 2021
karenzone added a commit that referenced this pull request Jun 24, 2021
kares added a commit to kares/logstash that referenced this pull request Jul 1, 2021
* master: (41 commits)
  Test: resolve integration failure due ECS mode (elastic#13044)
  Feat: event factory support (elastic#13017)
  Doc: Add geoip database API to node stats (elastic#13019)
  Add geoip database metrics to /node/stats API (elastic#13004)
  ecs: on-by-default plus docs (elastic#12830)
  ispec: fix cross-spec leak from fatal error integration specs (elastic#13002)
  Fix UBI source URL (elastic#13008)
  update fpm to allow pkg creation on jdk11+jruby 9.2 (elastic#13005)
  Add unit test to grant that production aliases correspond to a published RubyGem (elastic#12993)
  Fix logstash.bat not setting exit code (elastic#12948)
  Use the OS separator to invoke gradlew from Rake script (elastic#13000)
  Allow per-pipeline config of ECS Compatibility mode via Central Management (elastic#12861)
  Update jinja2 dependency in docker build (elastic#12994)
  fix database manager with multiple pipelines (elastic#12862)
  Fix Reflections stack traces when process yml files in classpath and debug is enabled (elastic#12991)
  Fix/log4j routing to avoid create spurious file (elastic#12965)
  Deps: update JRuby to 9.2.19.0 (elastic#12989)
  Doc: Add tip for checking for existing field (elastic#12899)
  Added test to cover the installation of aliased plugins (elastic#12967)
  CI: Update logstash_release.json after 7.3.12 (elastic#12986)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants