Doc: Add tip for checking for existing field#12899
Merged
karenzone merged 3 commits intoelastic:masterfrom Jun 15, 2021
Merged
Conversation
Co-authored-by: Sebastian <gentunian@users.noreply.github.com>
Contributor
Author
|
@gentunian, thank you for sharing this info with the community. I welcome your input on both the content and the attribution. Please let me know if you would like to see any changes. |
Contributor
|
@karenzone looks good to me. By the way, almost 1.5 years passed since I managed to use that workaround. Did you checked that this still works in current logstash versions? I think it should, as it makes use of simple logic and |
Contributor
Author
|
Thanks, @gentunian. We will validate as part of the review process. |
kares
reviewed
Jun 15, 2021
Contributor
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
looking good, would rather use a consistent field naming convention as suggested
(dashed_lower_case aligns with ECS naming conventions)
Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
kares
reviewed
Jun 15, 2021
karenzone
commented
Jun 15, 2021
Contributor
Author
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Builds cleanly and renders as expected
karenzone
added a commit
to karenzone/logstash
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Sebastian <gentunian@users.noreply.github.com> Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
karenzone
added a commit
to karenzone/logstash
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Sebastian <gentunian@users.noreply.github.com> Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
This was referenced Jun 15, 2021
karenzone
added a commit
that referenced
this pull request
Jun 15, 2021
Backports #12899 Co-authored-by: Sebastian <gentunian@users.noreply.github.com> Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
karenzone
added a commit
that referenced
this pull request
Jun 15, 2021
Backports #12899 Co-authored-by: Sebastian <gentunian@users.noreply.github.com> Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
kares
added a commit
to kares/logstash
that referenced
this pull request
Jul 1, 2021
* master: (41 commits) Test: resolve integration failure due ECS mode (elastic#13044) Feat: event factory support (elastic#13017) Doc: Add geoip database API to node stats (elastic#13019) Add geoip database metrics to /node/stats API (elastic#13004) ecs: on-by-default plus docs (elastic#12830) ispec: fix cross-spec leak from fatal error integration specs (elastic#13002) Fix UBI source URL (elastic#13008) update fpm to allow pkg creation on jdk11+jruby 9.2 (elastic#13005) Add unit test to grant that production aliases correspond to a published RubyGem (elastic#12993) Fix logstash.bat not setting exit code (elastic#12948) Use the OS separator to invoke gradlew from Rake script (elastic#13000) Allow per-pipeline config of ECS Compatibility mode via Central Management (elastic#12861) Update jinja2 dependency in docker build (elastic#12994) fix database manager with multiple pipelines (elastic#12862) Fix Reflections stack traces when process yml files in classpath and debug is enabled (elastic#12991) Fix/log4j routing to avoid create spurious file (elastic#12965) Deps: update JRuby to 9.2.19.0 (elastic#12989) Doc: Add tip for checking for existing field (elastic#12899) Added test to cover the installation of aliased plugins (elastic#12967) CI: Update logstash_release.json after 7.3.12 (elastic#12986) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Sebastian gentunian@users.noreply.github.com
Release notes
Doc: Add tip for how to see if a boolean field exists
What does this PR do?
Provides a work-around for checking to see if a boolean field exists (long standing issue)
Related issues
Preview
https://logstash_12899.docs-preview.app.elstc.co/guide/en/logstash/master/tips.html#tip-filters