Add unit test to grant that production aliases correspond to a published RubyGem#12993
Merged
andsel merged 5 commits intoelastic:masterfrom Jun 21, 2021
Merged
Conversation
Contributor
Author
|
Jenkins test this please |
1 similar comment
Contributor
Author
|
Jenkins test this please |
…hed RubyGem Loads the production plugin_aliases.yml definition file and check that every alias has a properly published gem on RubyGems,
andsel
force-pushed
the
feature/add_test_to_check_aliases_gems
branch
from
428b814 to
1abd759
Compare
jsvd
requested changes
Jun 21, 2021
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
Testing this locally I couldn't make the test fail.
My steps:
- edit
logstash-core/src/main/resources/org/logstash/plugins/AliasRegistry.yml:
input:
elastic_agent: beats
meh: tcp-
run
./gradlew javaTests --tests org.logstash.plugins.AliasRegistryTest.testProductionConfigAliasesGemsExists -
Observe that the test passes
It seems that the YAML isn't being loaded correctly, so the aliasesDefinitions Map is empty.
…in_aliases.yml' generated files
andsel
added a commit
to andsel/logstash
that referenced
this pull request
Jun 21, 2021
…hed RubyGem (elastic#12993) Loads the production plugin_aliases.yml definition file and check that every alias has a properly published gem on RubyGems. Adds clean up of plugin_aliases.yml files Fixed task dependency for copyPluginAlias (cherry picked from commit a5f3153)
kares
added a commit
to kares/logstash
that referenced
this pull request
Jul 1, 2021
* master: (41 commits) Test: resolve integration failure due ECS mode (elastic#13044) Feat: event factory support (elastic#13017) Doc: Add geoip database API to node stats (elastic#13019) Add geoip database metrics to /node/stats API (elastic#13004) ecs: on-by-default plus docs (elastic#12830) ispec: fix cross-spec leak from fatal error integration specs (elastic#13002) Fix UBI source URL (elastic#13008) update fpm to allow pkg creation on jdk11+jruby 9.2 (elastic#13005) Add unit test to grant that production aliases correspond to a published RubyGem (elastic#12993) Fix logstash.bat not setting exit code (elastic#12948) Use the OS separator to invoke gradlew from Rake script (elastic#13000) Allow per-pipeline config of ECS Compatibility mode via Central Management (elastic#12861) Update jinja2 dependency in docker build (elastic#12994) fix database manager with multiple pipelines (elastic#12862) Fix Reflections stack traces when process yml files in classpath and debug is enabled (elastic#12991) Fix/log4j routing to avoid create spurious file (elastic#12965) Deps: update JRuby to 9.2.19.0 (elastic#12989) Doc: Add tip for checking for existing field (elastic#12899) Added test to cover the installation of aliased plugins (elastic#12967) CI: Update logstash_release.json after 7.3.12 (elastic#12986) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Loads the production plugin_aliases.yml definition file and check that every alias has
a properly published gem on RubyGems.
plugin_aliases.ymlto Gradle's clean taskWhy is it important/What is the impact to the user?
Before aliasing a plugin in production that plugin must have an empty gem, this test grant for this during the testing of Logstash.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs