Merged
Conversation
This commit fix the source URL for UBI image to ensure that it stays consistent with the URL generated in https://artifacts.elastic.co/reports/dependencies/dependencies-current.html
robbavey
approved these changes
Jun 21, 2021
Member
robbavey
left a comment
robbavey
left a comment
There was a problem hiding this comment.
Thank you so much for doing this!
LGTM
Member
Author
|
Thanks @robbavey, is there a specific process to backport it to |
Member
Member
Author
|
Cool, merging and letting you handle the backport 👍🏻 |
robbavey
pushed a commit
to robbavey/logstash
that referenced
this pull request
Jun 21, 2021
Backport PR elastic#13008 to 7.13 branch. Original message: Fix UBI source URL (elastic#13008) This commit fix the source URL for UBI image to ensure that it stays consistent with the URL generated in https://artifacts.elastic.co/reports/dependencies/dependencies-current.html
robbavey
pushed a commit
to robbavey/logstash
that referenced
this pull request
Jun 21, 2021
Backport PR elastic#13008 to 7.x branch. Original message: This commit fix the source URL for UBI image to ensure that it stays consistent with the URL generated in https://artifacts.elastic.co/reports/dependencies/dependencies-current.html
This was referenced Jun 21, 2021
robbavey
added a commit
that referenced
this pull request
Jun 22, 2021
Backport PR #13008 to 7.x branch. Original message: This commit fix the source URL for UBI image to ensure that it stays consistent with the URL generated in https://artifacts.elastic.co/reports/dependencies/dependencies-current.html Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
robbavey
added a commit
that referenced
this pull request
Jun 22, 2021
Backport PR #13008 to 7.13 branch. Original message: Fix UBI source URL (#13008) This commit fix the source URL for UBI image to ensure that it stays consistent with the URL generated in https://artifacts.elastic.co/reports/dependencies/dependencies-current.html Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
kares
added a commit
to kares/logstash
that referenced
this pull request
Jul 1, 2021
* master: (41 commits) Test: resolve integration failure due ECS mode (elastic#13044) Feat: event factory support (elastic#13017) Doc: Add geoip database API to node stats (elastic#13019) Add geoip database metrics to /node/stats API (elastic#13004) ecs: on-by-default plus docs (elastic#12830) ispec: fix cross-spec leak from fatal error integration specs (elastic#13002) Fix UBI source URL (elastic#13008) update fpm to allow pkg creation on jdk11+jruby 9.2 (elastic#13005) Add unit test to grant that production aliases correspond to a published RubyGem (elastic#12993) Fix logstash.bat not setting exit code (elastic#12948) Use the OS separator to invoke gradlew from Rake script (elastic#13000) Allow per-pipeline config of ECS Compatibility mode via Central Management (elastic#12861) Update jinja2 dependency in docker build (elastic#12994) fix database manager with multiple pipelines (elastic#12862) Fix Reflections stack traces when process yml files in classpath and debug is enabled (elastic#12991) Fix/log4j routing to avoid create spurious file (elastic#12965) Deps: update JRuby to 9.2.19.0 (elastic#12989) Doc: Add tip for checking for existing field (elastic#12899) Added test to cover the installation of aliased plugins (elastic#12967) CI: Update logstash_release.json after 7.3.12 (elastic#12986) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit fix the source URL for UBI image to ensure that it stays
consistent with the URL generated in
https://artifacts.elastic.co/reports/dependencies/dependencies-current.html
Why is it important/What is the impact to the user?
The
sourceURLcolumn contains a pointer to the source code, which is optional for most dependencies,but a requirement for some, such as the Red Hat Universal Base Image.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)sourceURLHow to test this PR locally
Run
ci/license_check.shand verify thatreport.csvincludes the good URL