ispec: fix cross-spec leak from fatal error integration specs#13002
Merged
yaauie merged 1 commit intoelastic:masterfrom Jun 21, 2021
Merged
ispec: fix cross-spec leak from fatal error integration specs#13002yaauie merged 1 commit intoelastic:masterfrom
yaauie merged 1 commit intoelastic:masterfrom
Conversation
Because the "Fatal Error" specs specifically inject fatal errors during execution, and do so by reacting to a "poison" event, the fatal error prevents the poison event from being ACK'd in the underlying queue. By specifying a one-off temporary data directory in these specs and cleaning up after ourselves, we ensure that a PQ containing un-ACK'd events isn't leaked to the next spec to run.
kares
approved these changes
Jun 21, 2021
Contributor
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
❤️ so much, haven't thought about these consequences at all
yaauie
added a commit
that referenced
this pull request
Jun 21, 2021
Because the "Fatal Error" specs specifically inject fatal errors during execution, and do so by reacting to a "poison" event, the fatal error prevents the poison event from being ACK'd in the underlying queue. By specifying a one-off temporary data directory in these specs and cleaning up after ourselves, we ensure that a PQ containing un-ACK'd events isn't leaked to the next spec to run. (cherry picked from commit 6032e5f)
Merged
3 tasks
yaauie
added a commit
that referenced
this pull request
Jun 21, 2021
#13013) Because the "Fatal Error" specs specifically inject fatal errors during execution, and do so by reacting to a "poison" event, the fatal error prevents the poison event from being ACK'd in the underlying queue. By specifying a one-off temporary data directory in these specs and cleaning up after ourselves, we ensure that a PQ containing un-ACK'd events isn't leaked to the next spec to run. (cherry picked from commit 6032e5f)
kares
added a commit
to kares/logstash
that referenced
this pull request
Jul 1, 2021
* master: (41 commits) Test: resolve integration failure due ECS mode (elastic#13044) Feat: event factory support (elastic#13017) Doc: Add geoip database API to node stats (elastic#13019) Add geoip database metrics to /node/stats API (elastic#13004) ecs: on-by-default plus docs (elastic#12830) ispec: fix cross-spec leak from fatal error integration specs (elastic#13002) Fix UBI source URL (elastic#13008) update fpm to allow pkg creation on jdk11+jruby 9.2 (elastic#13005) Add unit test to grant that production aliases correspond to a published RubyGem (elastic#12993) Fix logstash.bat not setting exit code (elastic#12948) Use the OS separator to invoke gradlew from Rake script (elastic#13000) Allow per-pipeline config of ECS Compatibility mode via Central Management (elastic#12861) Update jinja2 dependency in docker build (elastic#12994) fix database manager with multiple pipelines (elastic#12862) Fix Reflections stack traces when process yml files in classpath and debug is enabled (elastic#12991) Fix/log4j routing to avoid create spurious file (elastic#12965) Deps: update JRuby to 9.2.19.0 (elastic#12989) Doc: Add tip for checking for existing field (elastic#12899) Added test to cover the installation of aliased plugins (elastic#12967) CI: Update logstash_release.json after 7.3.12 (elastic#12986) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
FIxes cross-spec leak from "fatal error" integration specs
Because the "Fatal Error" specs specifically inject fatal errors during
execution, and do so by reacting to a "poison" event, the fatal error prevents
the poison event from being ACK'd in the underlying queue.
By specifying a one-off temporary data directory in these specs and cleaning up
after ourselves, we ensure that a PQ containing un-ACK'd events isn't leaked to
the next spec to run.
Why is it important/What is the impact to the user?
Resolves random flaky tests that were caused by being executed immediately after one of the "fatal error" tests.
In the following specific test run, the
Test Logstash configuration expands environment variables in all plugin blocksspec immediately followed one of the "fatal error" specs, which had left a "poison" event containing the message"a fatal error". Since only the "fatal error" spec knew how to convert this message into an actual fatal error, the event was processed "normally". Unfortunately, the spec being executed didn't expect it to be there and its assertions failed.Depending on what the next test to run validated, this "leak" may or may not end up breaking one of its unrelated assertions.
Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs