[Exploratory View] Mobile experience by shahzad31 · Pull Request #99565 · elastic/kibana

shahzad31 · 2021-05-07T05:44:52Z

Summary

Added mobile apm ios data, Latency, CPU Usage, Memory Usage

This only adds these parts in the exploratory view, this PR doesn't covers adding a link from APM view

Follow up would be to work in APM to add links like defined in #100759

APM changes

Had to update APM has data call to return the indices that are being used alongside has data boolean.

shahzad31 · 2021-05-27T15:12:25Z

@elasticmachine merge upstream

.../public/components/shared/exploratory_view/configurations/mobile/response_duration_config.ts

added additional default filters & breakdowns.

updated agent filter name to 'iOS/swift'

… into mobile-experience

shahzad31 · 2021-06-09T10:00:17Z

@elasticmachine merge upstream

bryce-b · 2021-06-09T20:40:20Z

This is looking really good!
I noticed something odd going on in the service version filter option... which doesn't show up in the breakdown:

… into mobile-experience

shahzad31 · 2021-06-10T15:17:23Z

@bryce-b that was a good catch, i have fixed that. it will only show relevant filters now.

elasticmachine · 2021-06-17T11:25:50Z

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke

LGTM. Love the framework you set up to easily add new data/report types.

dominiqueclarke · 2021-06-17T19:06:01Z

...ublic/components/shared/exploratory_view/configurations/mobile/device_distribution_config.ts

+      },
+    ],
+    hasOperationType: false,
+    defaultFilters: Object.keys(MobileFields),


Can you explain to me the difference between defaultFilters and filters.

sorry about naming here. i will update these soon. default filters should be uiFilters and filters should be default/base filters here.

dominiqueclarke · 2021-06-17T19:06:13Z

x-pack/plugins/observability/public/context/has_data_context.tsx

                },
              }));
+            };
+            switch (app) {


Seems like this could have a larger impact on the observability overview page. Should I smoke test the overview page as well?

Yes, that would be helpful

kibanamachine · 2021-06-17T20:31:14Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	242	246	+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`observability`	200	205	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	-9.0B
`observability`	454.9KB	464.2KB	+9.3KB
total			+9.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`apm`	30	29	-1
`observability`	10	11	+1
total			-0

Unknown metric groups

API count

id	before	after	diff
`observability`	200	205	+5

History

💚 Build #132104 succeeded 2289c58
💔 Build #132016 failed 0ecb538
💔 Build #132003 failed 22ef586
💔 Build #131998 failed 2a9e540
💔 Build #131993 failed ec009fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

kibanamachine · 2021-06-18T15:33:34Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 99565

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (447 commits) skip flaky suite (elastic#102366) [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274) Add email connector info for Elastic Cloud (elastic#91363) [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663) Do not double register dashboard url generator (elastic#102599) [TSVB] Replaces EuiCodeEditor 👉 Monaco editor (elastic#100684) [Discover] Update kibana.json adding owner and description (elastic#102292) [Exploratory View] Mobile experience (elastic#99565) chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669) [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314) [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581) TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494) [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co>

kibanamachine · 2021-06-21T17:15:26Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co> Co-authored-by: Shahzad <shahzad.muhammad@elastic.co> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co>

shahzad31 added 4 commits April 29, 2021 01:08

wip

5461cf8

Merge branch 'master' into mobile-experience

195ad59

Merge branch 'master' into mobile-experience

9e261b8

wip

9626988

bryce-b mentioned this pull request May 24, 2021

Exploratory-View ramp-up elastic/apm-agent-ios#30

Closed

shahzad31 changed the title ~~Mobile experience~~ [Exploratory View] Mobile experience May 27, 2021

formgeist mentioned this pull request May 27, 2021

[APM] Add "Analyze data" button to the Exploratory view for iOS/Swift and RUM agents and disable irrelevant components within the service views #100759

Closed

5 tasks

kibanamachine and others added 2 commits May 27, 2021 11:12

Merge branch 'master' into mobile-experience

850f555

Merge branch 'master' into mobile-experience

b522c08

AlexanderWert reviewed Jun 2, 2021

View reviewed changes

.../public/components/shared/exploratory_view/configurations/mobile/response_duration_config.ts Outdated Show resolved Hide resolved

shahzad31 and others added 7 commits June 2, 2021 19:21

update

720c68f

updated agent filter name to 'iOS/swift'

e8a678f

added additional default filters & breakdowns.

Merge pull request #4 from bryce-b/mobile-experience

5a260b2

updated agent filter name to 'iOS/swift'

Merge branch 'master' into mobile-experience

e2a6e1b

Merge branch 'mobile-experience' of https://github.com/shahzad31/kibana…

32d36c2

… into mobile-experience

update memory and cpu

9884d27

fix

487e9c4

kibanamachine and others added 2 commits June 9, 2021 06:00

Merge branch 'master' into mobile-experience

24768ea

Merge branch 'master' into mobile-experience

41a76f3

shahzad31 added 6 commits June 10, 2021 09:45

Merge branch 'master' into mobile-experience

9ea07ec

fix types

f71aa48

Merge branch 'mobile-experience' of https://github.com/shahzad31/kibana…

dde04c3

… into mobile-experience

fix type and filters

2cb4f1a

Merge branch 'master' into mobile-experience

51569fa

fix image

e54969c

Merge branch 'master' into mobile-experience

1631c07

shahzad31 and others added 7 commits June 16, 2021 12:37

use i18n

dfc1690

Merge branch 'master' into mobile-experience

8ab2ddd

fix i18n

7f3bbc3

Added mobile device distribution config + fixed mobile field names

b1005cd

fixing chart type options and label for distribution

c949862

Merge pull request #6 from AlexanderWert/mobile-exploratory-view

ec009fb

Merge branch 'master' into mobile-experience

2a9e540

shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 17, 2021

shahzad31 added 5 commits June 17, 2021 13:44

fix types

22ef586

fix 18n

ebf4ec5

fix test

0ecb538

fix lint

2289c58

Merge branch 'master' into mobile-experience

067a7c3

dominiqueclarke approved these changes Jun 17, 2021

View reviewed changes

shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 17, 2021

shahzad31 merged commit 303806d into elastic:master Jun 18, 2021

shahzad31 deleted the mobile-experience branch June 18, 2021 15:30

shahzad31 added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021

shahzad31 mentioned this pull request Jun 21, 2021

[7.x] [Exploratory View] Mobile experience (#99565) #102773

Merged

kibanamachine mentioned this pull request Jun 21, 2021

[7.x] [Exploratory View] Mobile experience (#99565) #102774

Merged

paulb-elastic mentioned this pull request Jul 5, 2021

[Exploratory View] Add mobile APM elastic/uptime#324

Closed

Conversation

shahzad31 commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

APM changes

Uh oh!

shahzad31 commented May 27, 2021

Uh oh!

Uh oh!

shahzad31 commented Jun 9, 2021

Uh oh!

bryce-b commented Jun 9, 2021

Uh oh!

shahzad31 commented Jun 10, 2021

Uh oh!

elasticmachine commented Jun 17, 2021

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

shahzad31 Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

shahzad31 Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 17, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

Uh oh!

kibanamachine commented Jun 18, 2021

💔 Backport failed

Uh oh!

kibanamachine commented Jun 21, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shahzad31 commented May 7, 2021 •

edited

Loading