[Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details#102274
Merged
parkiino merged 7 commits intoelastic:masterfrom Jun 18, 2021
Merged
Conversation
parkiino
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
Contributor
|
Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint) |
Contributor
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
Some minor comments/questions
| }, [data]); | ||
|
|
||
| const agentStatusRow = { | ||
| title: 'Agent status', |
| tooltipContent={isolationFieldName} | ||
| value={`${isIsolated}`} | ||
| > | ||
| <EndpointHostIsolationStatus isIsolated={true} /> |
Contributor
There was a problem hiding this comment.
You don't show pending statuses from this view?
x-pack/plugins/security_solution/public/common/components/endpoint/agent_status.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
jenkins, test this (restarting due to jenkins upgrade) |
paul-tavares
approved these changes
Jun 17, 2021
Contributor
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
From our conversation - I left a few comments. I'm ok with you merging.
| }: { | ||
| agentId: string; | ||
| }): HostIsolationStatusResponse => { | ||
| const [isIsolated, setIsIsolated] = useState<Maybe<boolean>>(); |
Contributor
There was a problem hiding this comment.
This should be:
const [isIsolated, setIsIsolated] = useState<boolean>(false);
| tooltipContent={isolationFieldName} | ||
| value={`${isIsolated}`} | ||
| > | ||
| <EndpointHostIsolationStatus isIsolated={isIsolated as boolean} /> |
Contributor
There was a problem hiding this comment.
With above suggestion, you can avoid this cast.
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
Jun 21, 2021
…from alert details (elastic#102274)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 21, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (447 commits) skip flaky suite (elastic#102366) [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274) Add email connector info for Elastic Cloud (elastic#91363) [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663) Do not double register dashboard url generator (elastic#102599) [TSVB] Replaces EuiCodeEditor 👉 Monaco editor (elastic#100684) [Discover] Update kibana.json adding owner and description (elastic#102292) [Exploratory View] Mobile experience (elastic#99565) chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669) [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314) [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581) TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494) [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot