chore(NA): moving @kbn/ui-shared-deps into bazel by mistic · Pull Request #101669 · elastic/kibana

mistic · 2021-06-08T21:01:39Z

One step forward on #69706

That PR moves the @kbn/ui-shared-deps into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

…ils-bazel

…shared_built_assets

…d-deps-into-bazel

elasticmachine · 2021-06-10T18:33:05Z

Pinging @elastic/kibana-operations (Team:Operations)

packages/kbn-ui-shared-deps/webpack.config.js

jbudz · 2021-06-10T19:59:31Z

Hmm - testing on Windows, bootstrap and bundle compilation went through without any issues but the http server never listens. I switched between main and back to the branch to verify.

mistic · 2021-06-10T22:20:01Z

@jbudz do you mean when running yarn start?

jbudz · 2021-06-11T00:00:28Z

Yep - yarn kbn bootstrap && yarn start

mistic · 2021-06-11T13:36:52Z

@jbudz could you please re-check? I just tested and it is working okay. The only thing is that the optimizer just took more time to build the bundles then what it does on macos or linux

mistic · 2021-06-12T14:35:28Z

@elasticmachine merge upstream

mistic · 2021-06-14T11:55:47Z

@elasticmachine merge upstream

jbudz

LGTM. The earlier comment about the server not listening over http was probably on my end. There may be an inconsistency between Linux and Windows - I had to wait for elasticsearch to start on Windows. Either way, not relevant to this PR.

stephmilovic

Changes to cases and security_solution files LGTM 🏁

mistic · 2021-06-17T11:04:26Z

@elasticmachine merge upstream

packages/kbn-ui-shared-deps/webpack.config.js

jbudz

retested the webpack changes on Windows - LGTM

jbudz · 2021-06-17T20:07:09Z

(we discussed on slack, for posterity:) bffc49a pushed my Windows bootstrap time to 1h17m

This reverts commit bffc49a.

kibanamachine · 2021-06-18T00:25:27Z

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	503.7KB	504.2KB	+429.0B
`kbnUiSharedDeps-js`	6.4MB	6.4MB	-6.0B
total			+423.0B

History

💚 Build #132173 succeeded bffc49a
💚 Build #132161 succeeded 141c9d4
💚 Build #131992 succeeded b72028c
💚 Build #130887 succeeded e5356f2
💚 Build #130767 succeeded f0063e3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-06-18T15:11:56Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 101669

* chore(NA): moving @kbn/io-ts-utils into bazel * chore(NA): moving @kbn/ui-shared-deps into bazel * chore(NA): compelte working build for @kbn/ui-shared-deps * chore(NA): solve eslint problems * chore(NA): solve typechecking * chore(NA): debugger changes * chore(NA): update optimizer basic integration tests * chore(NA): ship kbn/ui-shared-deps metrics.json from new location at shared_built_assets * chore(NA): use correct ui-shared-deps metrics file location * chore(NA): remove webpack bazel config * chore(NA): implement improvements on webpack config * chore(NA): remove extra comment * chore(NA): try esbuild-loader minimizer * Revert "chore(NA): try esbuild-loader minimizer" This reverts commit bffc49a. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/scripts/jenkins_build_kibana.sh

…2666) * chore(NA): moving @kbn/ui-shared-deps into bazel (#101669) * chore(NA): moving @kbn/io-ts-utils into bazel * chore(NA): moving @kbn/ui-shared-deps into bazel * chore(NA): compelte working build for @kbn/ui-shared-deps * chore(NA): solve eslint problems * chore(NA): solve typechecking * chore(NA): debugger changes * chore(NA): update optimizer basic integration tests * chore(NA): ship kbn/ui-shared-deps metrics.json from new location at shared_built_assets * chore(NA): use correct ui-shared-deps metrics file location * chore(NA): remove webpack bazel config * chore(NA): implement improvements on webpack config * chore(NA): remove extra comment * chore(NA): try esbuild-loader minimizer * Revert "chore(NA): try esbuild-loader minimizer" This reverts commit bffc49a. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/scripts/jenkins_build_kibana.sh * chore(NA): last file containing old path for metrics.json file

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (447 commits) skip flaky suite (elastic#102366) [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274) Add email connector info for Elastic Cloud (elastic#91363) [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663) Do not double register dashboard url generator (elastic#102599) [TSVB] Replaces EuiCodeEditor 👉 Monaco editor (elastic#100684) [Discover] Update kibana.json adding owner and description (elastic#102292) [Exploratory View] Mobile experience (elastic#99565) chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669) [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314) [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581) TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494) [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

mistic added 13 commits May 27, 2021 19:26

chore(NA): moving @kbn/io-ts-utils into bazel

82843a7

Merge remote-tracking branch 'upstream/master' into move-kbn-io-ts-ut…

8117d2d

…ils-bazel

chore(NA): moving @kbn/ui-shared-deps into bazel

be2024d

chore(NA): merge and solve conflicts with master

6ae9749

chore(NA): compelte working build for @kbn/ui-shared-deps

844b906

chore(NA): solve eslint problems

5e32dc3

chore(NA): solve typechecking

e369814

chore(NA): debugger changes

fccd4cf

chore(NA): update optimizer basic integration tests

7d9006a

chore(NA): ship kbn/ui-shared-deps metrics.json from new location at …

c770a19

…shared_built_assets

chore(NA): use correct ui-shared-deps metrics file location

193d3f9

Merge remote-tracking branch 'upstream/master' into move-kbn-ui-share…

8142ffd

…d-deps-into-bazel

Merge remote-tracking branch 'upstream/master' into move-kbn-ui-share…

c4707ba

…d-deps-into-bazel

mistic marked this pull request as ready for review June 10, 2021 18:32

mistic requested review from a team as code owners June 10, 2021 18:32

mistic added chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.14.0 v8.0.0 labels Jun 10, 2021

mistic added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 10, 2021

mistic requested a review from jbudz June 10, 2021 18:33

jbudz reviewed Jun 10, 2021

View reviewed changes

packages/kbn-ui-shared-deps/webpack.config.js Outdated Show resolved Hide resolved

chore(NA): remove webpack bazel config

f9c6b9d

Merge branch 'master' into move-kbn-ui-shared-deps-into-bazel

f0063e3

Merge branch 'master' into move-kbn-ui-shared-deps-into-bazel

e5356f2

jbudz approved these changes Jun 14, 2021

View reviewed changes

stephmilovic approved these changes Jun 14, 2021

View reviewed changes

kibanamachine and others added 2 commits June 17, 2021 07:04

Merge branch 'master' into move-kbn-ui-shared-deps-into-bazel

b72028c

chore(NA): implement improvements on webpack config

141c9d4

jbudz reviewed Jun 17, 2021

View reviewed changes

packages/kbn-ui-shared-deps/webpack.config.js Outdated Show resolved Hide resolved

mistic added 2 commits June 17, 2021 18:22

chore(NA): remove extra comment

ba86e2b

chore(NA): try esbuild-loader minimizer

bffc49a

jbudz approved these changes Jun 17, 2021

View reviewed changes

Revert "chore(NA): try esbuild-loader minimizer"

b59264c

This reverts commit bffc49a.

mistic merged commit cee33b0 into elastic:master Jun 18, 2021

mistic mentioned this pull request Jun 18, 2021

[7.x] chore(NA): moving @kbn/ui-shared-deps into bazel (#101669) #102666

Merged

mistic mentioned this pull request Jun 21, 2021

chore(NA): remove problematic webpack config changes on @kbn/ui-shared-deps #102780

Merged

mistic mentioned this pull request Jul 1, 2021

Use Bazel for Kibana builds #69706

Closed

23 tasks

Conversation

mistic commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 10, 2021

Uh oh!

Uh oh!

jbudz commented Jun 10, 2021

Uh oh!

mistic commented Jun 10, 2021

Uh oh!

jbudz commented Jun 11, 2021

Uh oh!

mistic commented Jun 11, 2021

Uh oh!

mistic commented Jun 12, 2021

Uh oh!

mistic commented Jun 14, 2021

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

mistic commented Jun 17, 2021

Uh oh!

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

jbudz commented Jun 17, 2021

Uh oh!

kibanamachine commented Jun 18, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Uh oh!

kibanamachine commented Jun 18, 2021

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mistic commented Jun 8, 2021 •

edited

Loading