[TSVB] Index pattern select field disappear in Annotation tab by DianaDerevyankina · Pull Request #102314 · elastic/kibana

DianaDerevyankina · 2021-06-16T09:33:37Z

Summary

Fixed missed index pattern field for the annotations panel.
The reason was no fetchedIndex provided for IndexPatternSelect.

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2021-06-16T11:55:23Z

src/plugins/vis_type_timeseries/public/application/components/annotations_editor.js

    };
+    const changeFetchedIndex = async (index) => {
+      handleChange(index);
+      await this.setFetchedIndex(index[INDEX_PATTERN_NAME]);


how it should work in case of 2 or more annotations with different index patterns? Looks like you set in state the last fetchedIndex which will be used for each annotations.

alexwizp

I recommend you to put renderRow in a separate component. It should help you to solve that issue.

DianaDerevyankina · 2021-06-17T08:08:30Z

@elasticmachine merge upstream

alexwizp · 2021-06-17T08:36:05Z

src/plugins/vis_type_timeseries/public/application/components/annotation_row.tsx

+      query_string: filter,
+    });
+
+  const onChange = (part: Partial<Annotation>) =>


please use useCallback for these cases

src/plugins/vis_type_timeseries/public/application/components/annotation_row.tsx

alexwizp · 2021-06-17T08:38:35Z

src/plugins/vis_type_timeseries/public/application/components/annotation_row.tsx

+import { getDefaultQueryLanguage } from './lib/get_default_query_language';
+import type { Annotation, FetchedIndexPattern, IndexPatternValue } from '../../../common/types';
+import type { AnnotationsEditorProps } from './annotations_editor';
+import { newAnnotation } from './annotations_editor';


please avoid of cross references annotations_editor <---> annotations_ropw

alexwizp · 2021-06-17T08:40:17Z

src/plugins/vis_type_timeseries/public/application/components/yes_no.tsx

+import type { Annotation } from '../../../common/types';

-interface YesNoProps<ParamName extends keyof TimeseriesVisParams> {
+interface YesNoProps<ParamName extends keyof TimeseriesVisParams | keyof Annotation> {


wrong type. not sure that YesNo component should know anything about Annotation.

and TimeseriesVisParams. Looks like bad typed Component. Can we use string instead?

alexwizp · 2021-06-17T08:42:49Z

src/plugins/vis_type_timeseries/public/application/components/annotations_editor.tsx

+          defaultMessage="Click the button below to create an annotation data source."
+        />
+      </p>
+      <EuiButton fill onClick={() => collectionActions.handleAdd(props, newAnnotation)}>


see comment above, use useCallback

alexwizp · 2021-06-17T08:44:43Z

src/plugins/vis_type_timeseries/public/application/components/annotations_editor.tsx

+export interface AnnotationsEditorProps {
+  fields: VisFields;
+  model: Panel;
+  name: 'annotations';


what's a purpose of that field?

…Row, remove cross refecrence and update types

alexwizp · 2021-06-17T14:45:44Z

VladLasitsa · 2021-06-17T15:44:07Z

can we use the place more productively?

VladLasitsa

LGTM, tested locally in chrome

alexwizp

LGTM now

elasticmachine · 2021-06-18T11:11:40Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula

Thanx for the "typescripting" 🙂
I tested both a new and an existing visualization with annotations and it works fine.
Just some nit picks, in general LGTM

stratoula · 2021-06-18T11:47:16Z

src/plugins/vis_type_timeseries/public/application/components/annotation_row.tsx

+            </EuiFlexItem>
+            <EuiFlexItem>
+              <FieldSelect
+                type={'time_field'}


nit: No need to wrap it, type='time_field' and as we have done it for const INDEX_PATTERN_KEY = 'index_pattern'; we could do the same here

stratoula · 2021-06-18T11:47:49Z

src/plugins/vis_type_timeseries/public/application/components/annotation_row.tsx

+                }
+                restrict={RESTRICT_FIELDS}
+                value={model.time_field}
+                onChange={handleChange('time_field')}


Same here, could use the same constant.

stratoula · 2021-06-18T11:49:42Z

src/plugins/vis_type_timeseries/public/application/components/annotations_editor.tsx

+
+const NoContent = ({ handleAdd }: { handleAdd: () => void }) => (
+  <EuiText textAlign="center">
+    <p>


Nit, do we need the extra p ?

Yes... don't see any difference with and without p

I was wrong it affects UI, let's keep it as before

kibanamachine · 2021-06-18T14:29:14Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visTypeTimeseries`	505	506	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTimeseries`	1.7MB	1.7MB	+556.0B

History

💚 Build #132368 succeeded d018a26
💚 Build #132358 succeeded d72a653
💛 Build #132048 was flaky 22f270b
💚 Build #131991 succeeded a6b7220
💚 Build #131960 succeeded 2865704

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

…c#102314) * [TSVB] Index pattern select field disappear in Annotation tab * Refactor AnnotationsEditor and move renderRow logic into AnnotationRow * Remove duplicated license, add useCallback to functions in AnnotationRow, remove cross refecrence and update types * Refactor AnnotationEditor and AnnotationRow * refactoring * remove extra props * fix nits Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

…c#102314) * [TSVB] Index pattern select field disappear in Annotation tab * Refactor AnnotationsEditor and move renderRow logic into AnnotationRow * Remove duplicated license, add useCallback to functions in AnnotationRow, remove cross refecrence and update types * Refactor AnnotationEditor and AnnotationRow * refactoring * remove extra props * fix nits Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> # Conflicts: # src/plugins/vis_type_timeseries/public/application/components/yes_no.tsx

…102314) (#102654) * [TSVB] Index pattern select field disappear in Annotation tab (#102314) * [TSVB] Index pattern select field disappear in Annotation tab * Refactor AnnotationsEditor and move renderRow logic into AnnotationRow * Remove duplicated license, add useCallback to functions in AnnotationRow, remove cross refecrence and update types * Refactor AnnotationEditor and AnnotationRow * refactoring * remove extra props * fix nits Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> # Conflicts: # src/plugins/vis_type_timeseries/public/application/components/yes_no.tsx * fix merge conflicts Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>

… (#102653) * [TSVB] Index pattern select field disappear in Annotation tab * Refactor AnnotationsEditor and move renderRow logic into AnnotationRow * Remove duplicated license, add useCallback to functions in AnnotationRow, remove cross refecrence and update types * Refactor AnnotationEditor and AnnotationRow * refactoring * remove extra props * fix nits Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (447 commits) skip flaky suite (elastic#102366) [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274) Add email connector info for Elastic Cloud (elastic#91363) [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663) Do not double register dashboard url generator (elastic#102599) [TSVB] Replaces EuiCodeEditor 👉 Monaco editor (elastic#100684) [Discover] Update kibana.json adding owner and description (elastic#102292) [Exploratory View] Mobile experience (elastic#99565) chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669) [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314) [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581) TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494) [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

[TSVB] Index pattern select field disappear in Annotation tab

edcf328

DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 v7.14.0 labels Jun 16, 2021

DianaDerevyankina requested review from VladLasitsa and alexwizp June 16, 2021 09:33

DianaDerevyankina self-assigned this Jun 16, 2021

alexwizp reviewed Jun 16, 2021

View reviewed changes

alexwizp requested changes Jun 16, 2021

View reviewed changes

stratoula added the v7.13.3 label Jun 16, 2021

Refactor AnnotationsEditor and move renderRow logic into AnnotationRow

4574626

Merge branch 'master' into issues/102180

2865704

alexwizp reviewed Jun 17, 2021

View reviewed changes

src/plugins/vis_type_timeseries/public/application/components/annotation_row.tsx Show resolved Hide resolved

alexwizp reviewed Jun 17, 2021

View reviewed changes

DianaDerevyankina added 2 commits June 17, 2021 14:03

Remove duplicated license, add useCallback to functions in Annotation…

a6b7220

…Row, remove cross refecrence and update types

Refactor AnnotationEditor and AnnotationRow

22f270b

alexwizp added 3 commits June 18, 2021 12:46

refactoring

7a7c6b7

Merge remote-tracking branch 'upstream/master' into issues/102180

d72a653

remove extra props

d018a26

VladLasitsa approved these changes Jun 18, 2021

View reviewed changes

alexwizp approved these changes Jun 18, 2021

View reviewed changes

alexwizp marked this pull request as ready for review June 18, 2021 11:11

alexwizp requested a review from a team June 18, 2021 11:11

stratoula approved these changes Jun 18, 2021

View reviewed changes

fix nits

397da4a

alexwizp merged commit 853de83 into elastic:master Jun 18, 2021

alexwizp self-assigned this Jun 18, 2021

alexwizp mentioned this pull request Jun 18, 2021

[7.x] [TSVB] Index pattern select field disappear in Annotation tab (#102314) #102653

Merged

alexwizp mentioned this pull request Jun 18, 2021

[7.13] [TSVB] Index pattern select field disappear in Annotation tab (#102314) #102654

Merged

Conversation

DianaDerevyankina commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

For maintainers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

DianaDerevyankina commented Jun 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexwizp commented Jun 17, 2021

Uh oh!

VladLasitsa commented Jun 17, 2021

Uh oh!

VladLasitsa left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 18, 2021

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stratoula Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexwizp Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 18, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DianaDerevyankina commented Jun 16, 2021 •

edited

Loading

stratoula Jun 18, 2021 •

edited

Loading

alexwizp Jun 18, 2021 •

edited

Loading