Skip to content

TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0#102494

Merged
alexwizp merged 2 commits intoelastic:masterfrom
alexwizp:tsvb_timefied
Jun 18, 2021
Merged

TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0#102494
alexwizp merged 2 commits intoelastic:masterfrom
alexwizp:tsvb_timefied

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 17, 2021 •
edited
Loading

Part of: #100778

Summary

This is a follow-up PR that should fix the issue where the time field is not showing after upgrading from 7.12.1 to 7.13.0. Many of our users are using TSVB without a configured time field. In the previous implementation, this worked because we had no separation between ES and Kibana indexes.

After 7.13.0 we have 2 different modes for ES and Kibana indexes. The main problem here is that there is no default time field value in the ES index. As a result, the users see a message about no data.

Steps to reprocude:

  1. Install Sample data logs
  2. Import export (21).ndjson.zip
  3. Open imported visualization

Expected result: some data should be displayed

Screens

Before

image

After

image

@alexwizp alexwizp self-assigned this Jun 17, 2021
@alexwizp alexwizp requested a review from stratoula June 17, 2021 14:59
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 17, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp marked this pull request as ready for review June 17, 2021 16:13
@alexwizp alexwizp requested a review from a team June 17, 2021 16:13
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.13.3 v7.14.0 v8.0.0 labels Jun 17, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 17, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula reviewed Jun 18, 2021
View reviewed changes
src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/query.js
series,
esQueryConfig,
seriesIndex,
capabilities,
Copy link
Contributor

@stratoula stratoula Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add capabilities and uiSettings? They are not used anywhere in the query function.

Copy link
Contributor Author

@alexwizp alexwizp Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a disgusting part of processor implementations. This is a function that accepts a sequence of arguments. So it's important for us to keep order

Copy link
Contributor

@stratoula stratoula Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a comment? In order to not confuse us :D

Copy link
Contributor Author

@alexwizp alexwizp Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens across all request/response processors. I'll create an issue to fix that

stratoula
stratoula approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested it locally by migration 7.9.3 and 7.12.1 SOs that haven't defined their timefield and it works fine. I also tested 7.13.2 saved objects.

I would appreciate it if somebody else from the team could also test it thoroughly.
cc @dziyanadzeraviankina @VladLasitsa

VladLasitsa
VladLasitsa approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested 7.13.2 saved objects.

@alexwizp alexwizp merged commit b9f64b7 into elastic:master Jun 18, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 18, 2021
@alexwizp
TSVB visualizations with no timefield do not render after upgrading f…
a1ea361 
…rom 7.12.1 to 7.13.0 (elastic#102494)

* TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0

Part of: elastic#100778

* fix CI
@alexwizp alexwizp mentioned this pull request Jun 18, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 18, 2021
@alexwizp
TSVB visualizations with no timefield do not render after upgrading f…
62b8f6c 
…rom 7.12.1 to 7.13.0 (elastic#102494)

* TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0

Part of: elastic#100778

* fix CI
# Conflicts:
#	src/plugins/vis_type_timeseries/server/lib/vis_data/get_interval_and_timefield.ts
#	src/plugins/vis_type_timeseries/server/lib/vis_data/get_table_data.ts
#	src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js
#	src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.test.js
#	src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/table/date_histogram.js
@alexwizp alexwizp mentioned this pull request Jun 18, 2021
Merged
alexwizp added a commit that referenced this pull request Jun 18, 2021
@alexwizp
TSVB visualizations with no timefield do not render after upgrading f…
ecee040 
…rom 7.12.1 to 7.13.0 (#102494) (#102641)

* TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0

Part of: #100778

* fix CI
alexwizp added a commit that referenced this pull request Jun 18, 2021
@alexwizp
[7.13] TSVB visualizations with no timefield do not render after upgr…
cc29c83 
…ading from 7.12.1 to 7.13.0 (#102494) (#102645)

* TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (#102494)

* TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0

Part of: #100778

* fix CI
# Conflicts:
#	src/plugins/vis_type_timeseries/server/lib/vis_data/get_interval_and_timefield.ts
#	src/plugins/vis_type_timeseries/server/lib/vis_data/get_table_data.ts
#	src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js
#	src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.test.js
#	src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/table/date_histogram.js

* fix CI
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 21, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
72e3121 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (447 commits)
  skip flaky suite (elastic#102366)
  [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274)
  Add email connector info for Elastic Cloud (elastic#91363)
  [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663)
  Do not double register dashboard url generator (elastic#102599)
  [TSVB] Replaces EuiCodeEditor 👉 Monaco editor  (elastic#100684)
  [Discover] Update kibana.json adding owner and description (elastic#102292)
  [Exploratory View] Mobile experience (elastic#99565)
  chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669)
  [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314)
  [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581)
  TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494)
  [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236)
  [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506)
  [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384)
  [ML] Anomaly detection job custom_settings improvements (elastic#102099)
  [Cases] Route: Get all alerts attach to a case (elastic#101878)
  Fixes wrong list exception type when creating endpoint event filters list (elastic#102522)
  remove search bar that's not working yet (elastic#102550)
  Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
@stratoula stratoula mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

@DianaDerevyankina DianaDerevyankina Awaiting requested review from DianaDerevyankina

+1 more reviewer

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexwizp alexwizp

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.13.3 v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexwizp @kibanamachine @elasticmachine @VladLasitsa @stratoula