Upgrade EUI to v31.10.0 by chandlerprall · Pull Request #93796 · elastic/kibana

chandlerprall · 2021-03-05T16:28:43Z

31.8.0 ➡️ 31.10.0

Most snapshot changes are from Added a display and size props to EuiButtonIcon (Sort by score #4466)
Slight layout changes from EuiPage refactor (reason for dashboard baseline snapshot updates)

`31.10.0`

Added panelProps to EuiPopover (#4573)
Updated the default of the EuiPopovers ownFocus prop from false to true (#4551)
Added src prop to EuiImage as an alternative to url (#4611)
Added EuiSplitPanel component (#4539)

Bug fixes

Fixed hover effect of nested clickable rows in EuiBasicTable (#4566)
Fixed visual bug in drag&drop sections when nested in an popover (#4590)
Fixed an errant export of EuiSideNavProps type from JS code (#4604)
Fixed misaligned EuiComboBox options list (#4607)
Fixed missing forwardRef on EuiHeaderSectionItemButton (#4631)

`31.9.1`

Bug fixes

Fixed an errant export of two non-existant values (#4597)

`31.9.0`

Added EuiComboBoxOptionOption prop to EuiComboBox props table (#4563)
Allowed dynamically changing the direction prop on EuiResizableContainer (#4557)
Exported useIsWithinBreakpoints hook (#4557)
Added focus to EuiForm error EuiCallout (#4497)
Added a display and size props to EuiButtonIcon (#4466)

Bug fixes

Fixed the return type of getDefaultEuiMarkdownUiPlugins (#4567)
Fixed inverse handling of boolean sorting in EuiDataGrid (#4561)

Feature: EuiPageTemplate (#4517)

Added new EuiPageTemplate component as a shortcut for creating the different types of page layout patterns
Added props grow and direction to EuiPage
Added props panelled, panelProps, and paddingSize to EuiPageBody
Added props restrictWidth and paddingSize to EuiPageBody
Added prop paddingSize to EuiPageHeader
Updated tabs prop of EuiPageHeaderContent to render large size
Added prop sticky to EuiPageSideBar
Added Sass variable $euiPageSidebarMinWidth for changing default min-width of EuiPageSideBar
Added href and other anchor props to EuiHeaderSectionItemButton

Bug fixes

Fixed horizontal overflow of EuiPageContent
Fixed horizontal overflow of EuiBreadcrumbs

thompsongl · 2021-03-23T15:07:33Z

test/functional/apps/discover/_discover.ts

        });
        const newDurationHours = await PageObjects.timePicker.getTimeDurationInHours();
-        expect(Math.round(newDurationHours)).to.be(26);
+        expect(Math.round(newDurationHours)).to.be(27);


Changes to EuiPage increased padding on some containers, resulting in a slightly smaller histogram container, resulting in a fractionally larger brush area given the same absolute dimensions.

thompsongl · 2021-03-23T17:08:19Z

@elasticmachine merge upstream

…ts and is enabled

elasticmachine · 2021-03-24T23:08:15Z

Pinging @elastic/eui-design (EUI)

elasticmachine · 2021-03-25T09:57:43Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2021-03-25T09:57:43Z

Pinging @elastic/uptime (Team:uptime)

shahzad31 · 2021-03-25T10:11:02Z

.../components/monitor/status_details/location_map/__snapshots__/location_missing.test.tsx.snap

      id="popover"
      isOpen={false}
-      ownFocus={false}
+      ownFocus={true}


i wonder what will happen with this change.

flash1293

Can't find any breakages, but I'm not sure about that one change (left a comment)

flash1293 · 2021-03-25T11:13:39Z

src/plugins/discover/public/application/angular/doc_table/components/table_row/open.html

 <td ng-click="toggleRow()" data-test-subj="docTableExpandToggleColumn" class="kbnDocTableCell__toggleDetails">
  <button
-    class="euiButtonIcon euiButtonIcon--text"
+    class="euiButtonIcon euiButtonIcon--text euiButtonIcon--empty euiButtonIcon--xSmall"


Why is this necessary? In Discover I can't see any styles applied based on these classes.

The button(s) outlined in red use this template. Appears that Dashboard uses this Discover template.

Yeah, I found them in Kibana, but I couldn't find any CSS rules attached to the new classes.

Uses the :not(.euiButtonIcon--empty) selector to prevent certain default styles from being applied, rather than adding specific styles.

peteharverson

Changes to the Transforms functional tests LGTM.

flash1293

LGTM, thanks for explaining @thompsongl

smith

APM changes look good!

thompsongl · 2021-03-25T18:35:49Z

@elasticmachine merge upstream

legrego

Security changes LGTM

poffdeluxe

Presentation changes LGTM

stephmilovic

LGTM thanks @chandlerprall 🚀 🎸 👨‍🎤

kibanamachine · 2021-03-29T16:17:32Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 25172ba
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-securitySolutionCypressChrome

Test Failures

Kibana Pipeline / general / Closes and opens alerts.Closing alerts Closes and opens alerts

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: expected '<span.euiBadge.euiBadge--hollow.euiBadge--iconLeft>' to have text '197', but the text was '297'
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/closing.spec.ts:20202:43)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	388.9KB	389.0KB	+43.0B
`lens`	957.7KB	957.9KB	+184.0B
`security`	686.1KB	686.2KB	+92.0B
`securitySolution`	7.2MB	7.2MB	+476.0B
`triggersActionsUi`	1.5MB	1.5MB	+828.0B
total			+1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	412.3KB	412.5KB	+184.0B
`data`	802.5KB	802.7KB	+192.0B
`searchprofiler`	45.7KB	47.1KB	+1.4KB
`visTypeTimeseries`	126.8KB	129.9KB	+3.1KB
total			+4.8KB

Unknown metric groups

@kbn/ui-shared-deps asset size

id	before	after	diff
`css`	590.4KB	607.9KB	+17.5KB
`kbn-ui-shared-deps.@elastic.js`	3.3MB	3.3MB	+9.2KB
`kbn-ui-shared-deps.js`	6.7MB	6.7MB	+2.0B
total			+26.7KB

History

💚 Build #115537 succeeded f2d64de
💔 Build #115471 failed 7db445c
💛 Build #115300 was flaky 4be989c
💚 Build #115033 succeeded 593a66b
💔 Build #115009 failed bd66f47

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Upgrade EUI to v31.10.0 (#93796) * Upgraded eui version, updated jest snaapshots * Upgrade EUI to v31.10.0 & update tests * increase expected histogram brush size result * revert dev_server snap * update baseline dashboard reporting png * avoid multiple acton menu openings when verified that the action exists and is enabled * update dashboard table expand button * update dashboard tsvb baseline * Adjust 2 cypress tests * snapshot update Co-authored-by: Greg Thompson <thompson.glowe@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/functional/screenshots/baseline/tsvb_dashboard.png # x-pack/plugins/canvas/public/components/asset_manager/__stories__/__snapshots__/asset_manager.stories.storyshot # x-pack/plugins/security_solution/public/management/pages/trusted_apps/view/__snapshots__/trusted_apps_page.test.tsx.snap * snapshot updates

Upgraded eui version, updated jest snaapshots

98a768a

chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.13.0 labels Mar 5, 2021

chandlerprall changed the title ~~Upgraded eui version, updated jest snaapshots~~ Upgrade EUI to v31.9.1 Mar 5, 2021

chandlerprall added 2 commits March 8, 2021 10:13

Merge branch 'master' into eui-31-9-1

e1fb248

Merge branch 'master' into eui-31-9-1

02c2abb

chandlerprall changed the title ~~Upgrade EUI to v31.9.1~~ Upgrade EUI to v31.10.0 Mar 18, 2021

chandlerprall and others added 2 commits March 18, 2021 15:10

Upgrade EUI to v31.10.0 & update tests

3b875fc

increase expected histogram brush size result

b2048db

thompsongl reviewed Mar 23, 2021

View reviewed changes

kibanamachine and others added 3 commits March 23, 2021 13:08

Merge branch 'master' into eui-31-9-1

bc51b72

revert dev_server snap

97695d9

update baseline dashboard reporting png

3a8b8ef

jloleysens mentioned this pull request Mar 24, 2021

[Ingest pipelines] Prepare processors editor for EUI v8 (Amsterdam theme) #95310

Merged

thompsongl and others added 4 commits March 24, 2021 09:36

avoid multiple acton menu openings when verified that the action exis…

4798131

…ts and is enabled

update dashboard table expand button

43bba93

update dashboard tsvb baseline

bd66f47

Adjust 2 cypress tests

593a66b

thompsongl marked this pull request as ready for review March 24, 2021 23:08

thompsongl requested a review from a team March 24, 2021 23:08

thompsongl requested a review from a team as a code owner March 24, 2021 23:08

thompsongl requested a review from a team March 24, 2021 23:08

thompsongl requested review from a team as code owners March 24, 2021 23:08

pgayvallet approved these changes Mar 25, 2021

View reviewed changes

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Mar 25, 2021

shahzad31 reviewed Mar 25, 2021

View reviewed changes

jloleysens approved these changes Mar 25, 2021

View reviewed changes

shahzad31 approved these changes Mar 25, 2021

View reviewed changes

flash1293 reviewed Mar 25, 2021

View reviewed changes

peteharverson approved these changes Mar 25, 2021

View reviewed changes

flash1293 approved these changes Mar 25, 2021

View reviewed changes

smith approved these changes Mar 25, 2021

View reviewed changes

Merge branch 'master' into eui-31-9-1

4be989c

legrego approved these changes Mar 25, 2021

View reviewed changes

Merge branch 'master' into eui-31-9-1

7db445c

streamich approved these changes Mar 26, 2021

View reviewed changes

poffdeluxe approved these changes Mar 26, 2021

View reviewed changes

snapshot update

f2d64de

stephmilovic approved these changes Mar 27, 2021

View reviewed changes

Merge branch 'master' into eui-31-9-1

25172ba

chandlerprall merged commit f667aa2 into elastic:master Mar 29, 2021

chandlerprall deleted the eui-31-9-1 branch March 29, 2021 17:20

chandlerprall mentioned this pull request Mar 29, 2021

[7.x] Upgrade EUI to v31.10.0 (#93796) #95687

Merged

Conversation

chandlerprall commented Mar 5, 2021 • edited by thompsongl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Feature: EuiPageTemplate (#4517)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Mar 23, 2021

Uh oh!

elasticmachine commented Mar 24, 2021

Uh oh!

elasticmachine commented Mar 25, 2021

Uh oh!

elasticmachine commented Mar 25, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Mar 25, 2021

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 29, 2021

💛 Build succeeded, but was flaky

Stack Trace

Metrics [docs]

Async chunks

Page load bundle

@kbn/ui-shared-deps asset size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

chandlerprall commented Mar 5, 2021 •

edited by thompsongl

Loading