[Ingest pipelines] Prepare processors editor for EUI v8 (Amsterdam theme)#95310
Merged
jloleysens merged 3 commits intoelastic:masterfrom Mar 31, 2021
Merged
Conversation
jloleysens
added
v8.0.0
Team:Kibana Management
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ryankeairns
approved these changes
Mar 30, 2021
alisonelizabeth
approved these changes
Mar 30, 2021
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
jloleysens
added a commit
that referenced
this pull request
Mar 31, 2021
…eme) (#95310) (#95889) * remove shadows from eui panel at all levels * added "hasBorder" to support nested panels Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current master
With the EUI v7 theme, the Ingest pipeline editor looks like:
The top-level panels have a shadow applied to create a bit of depth with panels nested inside of other panels having no shadow to give a flat appearance.
On the new Amsterdam light theme the ingest pipelines editor looks like:
Because the default is for panels to be borderless, the nested panel looks indistinct from the containing panel. Additionally, the box shadow has a larger area which creates a dark gradient that gets cut off sharply. The bottom of the editor is where this is most pronounced:
After these changes
To make the editor look good in both v7 and v8 we can remove shadows at all levels (i.e., make the entire tree flat) and add borders on nested panel items (or all panel items). Pending the ability to set
hasBorderon #93796. SettinghasShadow={false}creates the following visual appearance:v7:
v8: