[EuiDataGrid] Inverse handling of boolean sorting#4561
[EuiDataGrid] Inverse handling of boolean sorting#4561chandlerprall merged 21 commits intoelastic:masterfrom
Conversation
fixed invalid link (elastic#4520)
[Page layouts] Updates to [EuiSideNav] (elastic#4488)
Fixed disabled text styles in Safari (and iOS) (elastic#4538)
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Co-authored-by: Akash Gupta <akashgp9@gmail.com>
chandlerprall
left a comment
There was a problem hiding this comment.
Thanks for picking this one up too, couple of comments:
Please revert the deletion of docs/bundle.min.js.map
This change inverts the text as needed but not the sorting logic which is located on lines 93-99. For testing, there is a boolean column on the _Data grid schemas and popovers
_ example
|
Done with the changes @chandlerprall |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4561/ |
chandlerprall
left a comment
There was a problem hiding this comment.
I've pushed an update to the changelog entry - we made a new EUI release and that causes git to place unmerged changelog items in the wrong section.
Tested these changes locally in the Data grid schemas and popovers example, will merge when CI passes.
|
jenkins test this |
|
@git-anurag-hub Thanks again! One thing to note for future changes: please create a new branch from |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4561/ |
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4561/ |
Yeah sorry for that will keep that in mind. :-\ |
|
CI timed out again; running tests locally to confirm everything is good, then merging |
Summary
Solved:- EuiDataGrid should switch handling of Boolean sorting. When there's ascending sorting, false values should be first, and the sorting text should be Sort False-True.
#4526
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes