Remove EuiPageSideProps from src/components/index.js export#4604
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Mar 3, 2021
Merged
Remove EuiPageSideProps from src/components/index.js export#4604chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall merged 3 commits intoelastic:masterfrom
Conversation
cchaos
approved these changes
Mar 3, 2021
thompsongl
approved these changes
Mar 3, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4604/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4604/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an additional exported type identified in #4597 (comment). This one wasn't reported during a webpack build presumably because its source file does
export * fromcompared to the explicitexport { ComponentProps}pattern which exported the others. This is the last occurrence ofpropsin src/components/index.js.Looked into making CI fail if webpack issued the warning about an unknown import but decided against for a few reasons:
distbuild or devserver+axe configurations, which is brittleSo to me it isn't worth it, but I can be told otherwise :)