Skip to content

Remove EuiPageSideProps from src/components/index.js export#4604

Merged
chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall:exported-types-cleanup
Mar 3, 2021
Merged

Remove EuiPageSideProps from src/components/index.js export#4604
chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall:exported-types-cleanup

Conversation

@chandlerprall
Copy link
Contributor

Summary

Removes an additional exported type identified in #4597 (comment). This one wasn't reported during a webpack build presumably because its source file does export * from compared to the explicit export { ComponentProps} pattern which exported the others. This is the last occurrence of props in src/components/index.js.

Looked into making CI fail if webpack issued the warning about an unknown import but decided against for a few reasons:

  • looks like it requires adding a plugin e.g. https://www.npmjs.com/package/fail-on-errors-webpack-plugin
  • we'd have to shoe-horn it into the CI environment for dist build or devserver+axe configurations, which is brittle
  • final conversion of index.js->TypeScript will need to handle this in an entirely different way

So to me it isn't worth it, but I can be told otherwise :)

@chandlerprall chandlerprall added skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) and removed skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Mar 3, 2021
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4604/

@chandlerprall chandlerprall merged commit 58a4035 into elastic:master Mar 3, 2021
@chandlerprall chandlerprall deleted the exported-types-cleanup branch March 3, 2021 19:45
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4604/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants