[EuiResizableContainer] Allow dynamic direction#4557
[EuiResizableContainer] Allow dynamic direction#4557thompsongl merged 9 commits intoelastic:masterfrom
direction#4557Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/ |
|
jenkins test this
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/ |
src/components/resizable_container/resizable_collapse_button.tsx
Outdated
Show resolved
Hide resolved
I'd actually love to keep an example in the docs for others to use and to keep track to ensure it continues to behave properly. |
Keep the modifications to the current example, or create a new section? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/ |
Either, or, just make it clear somwhere that that example exemplifies this behavior. |
src-docs/src/views/resizable_container/resizable_panel_collapsible.js
Outdated
Show resolved
Hide resolved
This reverts commit 55f82af.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/ |
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Works great! Thanks! In a follow up, it'd be great to also maintain the collapsed state when shifting between layouts.
src-docs/src/views/resizable_container/resizable_panel_collapsible_responsive.js
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/ |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; Tested locally & new example in deployed docs
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/ |
4 participants
Summary
Closes #4555 by allowing for changing the
directionprop and preventing state errors during panel re-registry.See to-be-reverted docs "Simple" example for a demo.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests