[ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. by walterra · Pull Request #84605 · elastic/kibana

walterra · 2020-12-01T08:38:58Z

Summary

Passing in an empty string '' to useResolver() would trigger a wild card search across all indices and fields, potentially causing a timeout and the page would fail to load. The following pages were affected:

Single Metric Viewer
Data frame analytics models list
Data frame analytics jobs list
Data frame analytics exploration page
File Data Visualizer (Data visualizer - Import data from a log file)

This PR fixes it by passing undefined instead of '' to useResolver to avoid calling _fields_for_wildcard with an empty pattern. Jest tests were added to cover the two parameter scenarios empty string/undefined.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

peteharverson · 2020-12-01T12:54:04Z

x-pack/plugins/ml/public/application/routing/use_resolver.ts

+        }

-          const { combinedQuery } = createSearchItems(config, indexPattern!, savedSearch);
+        // note, currently we're using our own kibana context that requires a current index pattern to be set


Is it worth adding a comment to clarify that for pages that don't require an index pattern, undefined should be passed for the index pattern and saved search IDs?

Added comments here: 2a916a9

elasticmachine · 2020-12-01T15:10:58Z

Pinging @elastic/ml-ui (:ml)

peteharverson

Tested and LGTM

qn895 · 2020-12-01T16:07:21Z

Tested and LGTM

kibanamachine · 2020-12-01T16:52:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7a10651

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.2MB	5.2MB	+388.0B

History

💛 Build #90995 was flaky 668e0b1
💚 Build #90982 succeeded 1af2323
💔 Build #90962 failed 5412b39

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…gin routes. (elastic#84605) Passing in an empty string '' to useResolver() would trigger a wild card search across all indices and fields, potentially causing a timeout and the page would fail to load. The following pages were affected: Single Metric Viewer, Data frame analytics models list, Data frame analytics jobs list, Data frame analytics exploration page, File Data Visualizer (Data visualizer - Import data from a log file). This PR fixes it by passing undefined instead of '' to useResolver to avoid calling _fields_for_wildcard with an empty pattern. Jest tests were added to cover the two parameter scenarios empty string/undefined.

…gin routes. (elastic#84605) Passing in an empty string '' to useResolver() would trigger a wild card search across all indices and fields, potentially causing a timeout and the page would fail to load. The following pages were affected: Single Metric Viewer, Data frame analytics models list, Data frame analytics jobs list, Data frame analytics exploration page, File Data Visualizer (Data visualizer - Import data from a log file). This PR fixes it by passing undefined instead of '' to useResolver to avoid calling _fields_for_wildcard with an empty pattern. Jest tests were added to cover the two parameter scenarios empty string/undefined. # Conflicts: # x-pack/plugins/ml/public/application/routing/routes/data_frame_analytics/analytics_job_exploration.tsx # x-pack/plugins/ml/public/application/routing/routes/data_frame_analytics/analytics_map.tsx

* master: (63 commits) Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)" (elastic#84662) declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660) Remove unscripted fields from sample data index-pattern saved objects (elastic#84659) [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605) Update create.asciidoc (elastic#84046) [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525) Fix flaky test suite (elastic#84602) [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293) Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)" Update code-comments describing babel plugins (elastic#84622) [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745) [Discover] Unskip doc table tests (elastic#84564) [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511) [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519) Return early when parallel install process detected (elastic#84190) [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723) [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490) [Fleet] Update agent details page (elastic#84434) adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578) [Search] Integrate "Send to background" UI with session service (elastic#83073) ...

…gin routes. (#84605) (#84680) Passing in an empty string '' to useResolver() would trigger a wild card search across all indices and fields, potentially causing a timeout and the page would fail to load. The following pages were affected: Single Metric Viewer, Data frame analytics models list, Data frame analytics jobs list, Data frame analytics exploration page, File Data Visualizer (Data visualizer - Import data from a log file). This PR fixes it by passing undefined instead of '' to useResolver to avoid calling _fields_for_wildcard with an empty pattern. Jest tests were added to cover the two parameter scenarios empty string/undefined.

…gin routes. (#84605) (#84682) Passing in an empty string '' to useResolver() would trigger a wild card search across all indices and fields, potentially causing a timeout and the page would fail to load. The following pages were affected: Single Metric Viewer, Data frame analytics models list, Data frame analytics jobs list, Data frame analytics exploration page, File Data Visualizer (Data visualizer - Import data from a log file). This PR fixes it by passing undefined instead of '' to useResolver to avoid calling _fields_for_wildcard with an empty pattern. Jest tests were added to cover the two parameter scenarios empty string/undefined.

[ML] Don't pass empty strings to useResolver.

5412b39

walterra self-assigned this Dec 1, 2020

walterra added the release_note:fix label Dec 1, 2020

walterra added 2 commits December 1, 2020 11:35

[ML] Fix analytics results page.

1af2323

[ML] Adds jest tests.

668e0b1

walterra force-pushed the ml-fix-use-resolver branch from 4352037 to 668e0b1 Compare December 1, 2020 12:23

peteharverson reviewed Dec 1, 2020

View reviewed changes

add comment, extend test.

2a916a9

walterra marked this pull request as ready for review December 1, 2020 15:10

walterra requested a review from a team as a code owner December 1, 2020 15:10

[ML] remove outdated comment

7a10651

walterra requested a review from qn895 December 1, 2020 15:14

walterra changed the title ~~[ML] Don't pass empty strings to useResolver.~~ [ML] Avoid passing empty strings to useResolver(). Dec 1, 2020

walterra changed the title ~~[ML] Avoid passing empty strings to useResolver().~~ [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes Dec 1, 2020

walterra changed the title ~~[ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes~~ [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. Dec 1, 2020

peteharverson approved these changes Dec 1, 2020

View reviewed changes

qn895 approved these changes Dec 1, 2020

View reviewed changes

walterra merged commit 5889e36 into elastic:master Dec 1, 2020

walterra deleted the ml-fix-use-resolver branch December 1, 2020 17:06

walterra mentioned this pull request Dec 1, 2020

[7.x] [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (#84605) #84680

Merged

walterra mentioned this pull request Dec 1, 2020

[7.10] [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (#84605) #84682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes.#84605

[ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes.#84605
walterra merged 5 commits intoelastic:masterfrom
walterra:ml-fix-use-resolver

walterra commented Dec 1, 2020 •

edited by peteharverson

Loading

Uh oh!

peteharverson Dec 1, 2020

Uh oh!

walterra Dec 1, 2020

Uh oh!

elasticmachine commented Dec 1, 2020

Uh oh!

peteharverson left a comment

Uh oh!

qn895 commented Dec 1, 2020

Uh oh!

kibanamachine commented Dec 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

walterra commented Dec 1, 2020 • edited by peteharverson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

peteharverson Dec 1, 2020

Choose a reason for hiding this comment

Uh oh!

walterra Dec 1, 2020

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 1, 2020

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

qn895 commented Dec 1, 2020

Uh oh!

kibanamachine commented Dec 1, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

walterra commented Dec 1, 2020 •

edited by peteharverson

Loading