[Security Solution][Detections] Fix labels and issue with mandatory fields#84525
Merged
cnasikas merged 2 commits intoelastic:masterfrom Dec 1, 2020
Merged
[Security Solution][Detections] Fix labels and issue with mandatory fields#84525cnasikas merged 2 commits intoelastic:masterfrom
cnasikas merged 2 commits intoelastic:masterfrom
Conversation
cnasikas
added
bug
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
cnasikas
force-pushed
the
fix_84472_84475
branch
from
eb1ff8f to
29c8ed8
Compare
cnasikas
force-pushed
the
fix_84472_84475
branch
from
29c8ed8 to
902c7e5
Compare
mikecote
approved these changes
Nov 30, 2020
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
LGTM! I left a few questions
.../triggers_actions_ui/public/application/components/builtin_action_types/jira/translations.ts
Outdated
Show resolved
Hide resolved
...gers_actions_ui/public/application/components/builtin_action_types/resilient/translations.ts
Outdated
Show resolved
Hide resolved
...gers_actions_ui/public/application/components/builtin_action_types/resilient/translations.ts
Outdated
Show resolved
Hide resolved
cnasikas
force-pushed
the
fix_84472_84475
branch
from
3176cba to
9362dcd
Compare
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 1, 2020
* master: (63 commits) Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)" (elastic#84662) declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660) Remove unscripted fields from sample data index-pattern saved objects (elastic#84659) [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605) Update create.asciidoc (elastic#84046) [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525) Fix flaky test suite (elastic#84602) [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293) Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)" Update code-comments describing babel plugins (elastic#84622) [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745) [Discover] Unskip doc table tests (elastic#84564) [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511) [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519) Return early when parallel install process detected (elastic#84190) [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723) [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490) [Fleet] Update agent details page (elastic#84434) adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578) [Search] Integrate "Send to background" UI with session service (elastic#83073) ...
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Dec 1, 2020
…ields (elastic#84525) * Fix labeling and bugs * Improve naming
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Dec 1, 2020
…ields (elastic#84525) * Fix labeling and bugs * Improve naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the following issues:
#84472, #84475
Checklist
Delete any items that are not applicable to this PR.
For maintainers