[Lens] (Accessibility) Improve landmarks in Lens#84511
Merged
mbondyra merged 1 commit intoelastic:masterfrom Dec 1, 2020
Merged
[Lens] (Accessibility) Improve landmarks in Lens#84511mbondyra merged 1 commit intoelastic:masterfrom
mbondyra merged 1 commit intoelastic:masterfrom
Conversation
mbondyra
added
Team:Visualizations
mbondyra
requested review from
a team,
dej611,
flash1293,
myasonik and
wylieconlon
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
approved these changes
Dec 1, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in Firefox and Chrome, still looks the same and works fine, LGTM
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 1, 2020
* master: (63 commits) Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)" (elastic#84662) declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660) Remove unscripted fields from sample data index-pattern saved objects (elastic#84659) [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605) Update create.asciidoc (elastic#84046) [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525) Fix flaky test suite (elastic#84602) [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293) Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)" Update code-comments describing babel plugins (elastic#84622) [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745) [Discover] Unskip doc table tests (elastic#84564) [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511) [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519) Return early when parallel install process detected (elastic#84190) [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723) [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490) [Fleet] Update agent details page (elastic#84434) adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578) [Search] Integrate "Send to background" UI with session service (elastic#83073) ...
mbondyra
added a commit
that referenced
this pull request
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #83597
All 3 sections should be wrapped in a
<main>Added
aria-labelledby={[element withUnsaved visualizationmessage]}The 3 sections should be wrapped in
<section>tagsEach section should have an
h2with what that section is (can be visually hidden). Maybe "Fields list", "Visualization workspace", and "Layer controls" but y'all know your app best. (I've chosen names: Data panel, Visualization workspace, Config Panel)Improve the content in the
<h1>for the unsaved state: right now, it just puts the heading at Unsaved but doesn't really tell you what page you're on or what's unsaved. Maybe Unsaved Lens Visualization is a better<h1>though feel free to suggest whatever you think might be most descriptive. - done in another PR ([Lens] accessibility screen reader issues #84395)