Update create.asciidoc - Url examples for api in specific space was missing the /api section by balooka · Pull Request #84046 · elastic/kibana

balooka · 2020-11-23T09:54:44Z

The url templates provided for call of the API with space information was missing the /api/ section in it.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2020-11-23T09:54:46Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

balooka · 2020-11-23T09:56:22Z

Apologies as it seems I'm not following the guidelines, was hoping a "simple" documentation change would work out easy,

elasticmachine · 2020-11-25T21:56:51Z

Pinging @elastic/kibana-docs (Team:Docs)

pmuellr · 2020-11-25T21:59:15Z

No worries @balooka, thanks for the PR!

I've added a label to direct to the right team, someone from there will help move this through the system.

KOTungseth

LGTM! Thanks for fixing this :)

legrego

LGTM as well, but I think we need to point this to master instead of 7.10. We can take care of the backports as needed

gchaps · 2020-11-30T20:29:53Z

@legrego master lists only three requests. Is that correct?

POST :/api/saved_objects/
POST :/api/saved_objects//
POST :/s/<space_id>/saved_objects/

legrego · 2020-11-30T20:40:26Z

In addition to those three, we should also have:

POST :/s/<space_id>/saved_objects/<type>/<id>

The url templates provided for call of the API with space information was missing the /api/ section in it. (cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

spalger · 2020-11-30T20:59:55Z

@elasticmachine merge upstream

spalger · 2020-11-30T21:00:17Z

jenkins test this

gchaps

LGTM

gchaps · 2020-11-30T22:12:59Z

@legrego Can you please take another look. Here is a preview:

https://kibana_84046.docs-preview.app.elstc.co/guide/en/kibana/master/saved-objects-api-create.html

legrego

LGTM, thanks!

The url templates provided for call of the API with space information was missing the /api/ section in it. (cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (63 commits) Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)" (elastic#84662) declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660) Remove unscripted fields from sample data index-pattern saved objects (elastic#84659) [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605) Update create.asciidoc (elastic#84046) [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525) Fix flaky test suite (elastic#84602) [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293) Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)" Update code-comments describing babel plugins (elastic#84622) [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745) [Discover] Unskip doc table tests (elastic#84564) [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511) [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519) Return early when parallel install process detected (elastic#84190) [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723) [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490) [Fleet] Update agent details page (elastic#84434) adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578) [Search] Integrate "Send to background" UI with session service (elastic#83073) ...

The url templates provided for call of the API with space information was missing the /api/ section in it. (cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Olivier V <vandamo.be@gmail.com>

* Update create.asciidoc (#84046) The url templates provided for call of the API with space information was missing the /api/ section in it. (cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [DOCS] Fixes requests Co-authored-by: Olivier V <vandamo.be@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine added the 💝community label Nov 23, 2020

pmuellr added the Team:Docs label Nov 25, 2020

jdddog mentioned this pull request Nov 30, 2020

Update create.asciidoc: fix documentation for creating saved objects within a space #84465

Closed

KOTungseth added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v7.6.0 v7.7.0 v7.8.0 v7.9.0 labels Nov 30, 2020

KOTungseth approved these changes Nov 30, 2020

View reviewed changes

legrego requested changes Nov 30, 2020

View reviewed changes

Update create.asciidoc

611fdaa

The url templates provided for call of the API with space information was missing the /api/ section in it. (cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

spalger force-pushed the patch-1 branch from 35f1cc1 to 611fdaa Compare November 30, 2020 20:58

spalger changed the base branch from 7.10 to master November 30, 2020 20:58

Merge branch 'master' into patch-1

45ba5d3

gchaps approved these changes Nov 30, 2020

View reviewed changes

legrego approved these changes Dec 1, 2020

View reviewed changes

gchaps merged commit 5420177 into elastic:master Dec 1, 2020

This was referenced Dec 1, 2020

[7.x] Update create.asciidoc (#84046) #84671

Merged

[7.10] Update create.asciidoc (#84046) #84672

Merged

gchaps mentioned this pull request Dec 1, 2020

[7.9] Update create.asciidoc (#84046) #84673

Merged

gchaps mentioned this pull request Dec 1, 2020

[7.8] Update create.asciidoc (#84046) #84674

Merged

gchaps mentioned this pull request Dec 1, 2020

[7.7] Update create.asciidoc (#84046) #84675

Merged

gchaps removed the v7.6.0 label Dec 1, 2020

Conversation

balooka commented Nov 23, 2020

Summary

Checklist

For maintainers

Uh oh!

kibanamachine commented Nov 23, 2020

Uh oh!

balooka commented Nov 23, 2020

Uh oh!

elasticmachine commented Nov 25, 2020

Uh oh!

pmuellr commented Nov 25, 2020

Uh oh!

KOTungseth left a comment

Choose a reason for hiding this comment

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

gchaps commented Nov 30, 2020

Uh oh!

legrego commented Nov 30, 2020

Uh oh!

spalger commented Nov 30, 2020

Uh oh!

spalger commented Nov 30, 2020

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

gchaps commented Nov 30, 2020

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants