Skip to content

Conversation

@gmmorris
Copy link
Contributor

Summary

merge of #75666 with #77868

Checklist

Delete any items that are not applicable to this PR.

For maintainers

mikecote and others added 30 commits August 21, 2020 11:42
)

* WIP step 1

* WIP step 2

* Cleanup

* Make maxWorkers an observable for the task pool

* Cleanup

* Fix test failures

* Use BehaviorSubject

* Add some tests
* Add errors$ observable to the task store

* Add unit tests
* master: (92 commits)
  [ILM] Data tiers for 7.10 (elastic#76126)
  [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789)
  [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654)
  Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746)
  [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598)
  [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688)
  fixed react warning in Suspense in alert flyout (elastic#77777)
  [APM] Track usage of Gold+ features (elastic#77630)
  Visualize: Bad request when working with histogram aggregation (elastic#77684)
  remove legacy ES plugin (elastic#77703)
  [Lens] change name of custom query to filters (elastic#77725)
  skip flaky suite (elastic#76239)
  remove visual aspects of baseline job (elastic#77815)
  skip flaky suite (elastic#77835)
  Fixes typo in data recognizer text (elastic#77691)
  management/update trusted_apps jest snapshot
  [build] Use Elastic hosted UBI minimal base image (elastic#77776)
  [APM] Add transaction error rate alert (elastic#76933)
  [Security Solution] [Detections] Remove file validation on import route (elastic#77770)
  [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698)
  ...
* master: (226 commits)
  [Enterprise Search] Added Logic for the Credentials View (elastic#77626)
  [CSM] Js errors (elastic#77919)
  Add the @kbn/apm-config-loader package (elastic#77855)
  [Security Solution] Refactor useSelector (elastic#75297)
  Implement tagcloud renderer (elastic#77910)
  [APM] Alerting: Add global option to create all alert types (elastic#78151)
  [Ingest pipelines] Upload indexed document to test a pipeline (elastic#77939)
  TypeScript cleanup in visualizations plugin (elastic#78428)
  Lazy load metric & mardown visualizations (elastic#78391)
  [Detections][EQL] EQL rule execution in detection engine (elastic#77419)
  Update tutorial-full-experience.asciidoc (elastic#75836)
  Update tutorial-define-index.asciidoc (elastic#75754)
  Add support for runtime field types to mappings editor. (elastic#77420)
  [Monitoring] Usage collection (elastic#75878)
  [Docs][Actions] Add docs for Jira and IBM Resilient (elastic#78316)
  [Security Solution][Resolver] Update @timestamp formatting (elastic#78166)
  [Security Solution] Fix app layout (elastic#76668)
  [Security Solution][Resolver] 2 new functions to DAL (elastic#78477)
  Adds new elasticsearch client to telemetry plugin (elastic#78046)
  skip flaky suite (elastic#78512) (elastic#78511) (elastic#78510) (elastic#78509) (elastic#78508) (elastic#78507) (elastic#78506) (elastic#78505) (elastic#78504) (elastic#78503) (elastic#78502) (elastic#78501) (elastic#78500)
  ...
* master:
  Fix APM lodash imports (elastic#78438)
  Add deprecated message to tile_map and region_map visualizations. (elastic#77683)
  Fix Lens smokescreen flaky tests (elastic#78566)
  updated discover with alt text (elastic#77660)
  Fix types (elastic#78619)
  Update tutorial-visualizing.asciidoc (elastic#76977)
  Update tutorial-discovering.asciidoc (elastic#76976)
  [Search] Error notification alignment (elastic#77788)
  Update tutorial-define-index.asciidoc (elastic#76975)
  [Lens] Fieldless operations (elastic#78080)
  [Usage Collection] [schema] Explicit "array" definition (elastic#78141)
  Update tutorial-define-index.asciidoc (elastic#76973)
  Fix --no-basepath references in doc (elastic#78570)
  Move StubIndexPattern to data plugin and convert to TS. (elastic#78518)
  Index pattern class - remove unused methods (elastic#78538)
  [Security Solution] [ALL] Eliminates all console.error and console.warn from Jest output (elastic#78523)
  [Actions] avoids setting a default dedupKey on PagerDuty (elastic#77773)
  First stab at developer-focussed saved objects docs (elastic#71430)
  remove unnecessary config validations (elastic#78527)
gmmorris and others added 28 commits October 5, 2020 13:58
…into feature/task_manager_429

* 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits)
  Add license check to direct package upload handler. (elastic#79653)
  [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (elastic#79193)
  [Security Solution][Resolver] Simplify CopyableField styling and add comments (elastic#79594)
  Fine-tunes ML related text on Metrics UI (elastic#79425)
  [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (elastic#79229)
  Add new "Add Data" tutorials (elastic#77237)
  Update APM telemetry docs (elastic#79583)
  Revert "Add support for runtime field types to mappings editor. (elastic#77420)" (elastic#79611)
  Kibana request headers (elastic#79218)
  ensure missing indexPattern error is bubbled up to error callout (elastic#79378)
  Missing space fix (elastic#79585)
  remove duplicate tab states (elastic#79501)
  [data.ui] Lazy load UI components in data plugin. (elastic#78889)
  Add generic type params to search dependency. (elastic#79608)
  [Ingest Manager] Internal action for policy reassign (elastic#78493)
  [ILM] Add index_codec to forcemerge action in hot and warm phases (elastic#78175)
  [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (elastic#79579)
  [ML] Hide Data Grid column options when histogram charts are enabled. (elastic#79459)
  [Telemetry] Synchronous `setup` and `start` methods (elastic#79457)
  [Observability] Persist time range across apps (elastic#79258)
  ...
* master: (217 commits)
  Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837)
  fix can't edit a scripted field with special char (elastic#79842)
  [ML] clear selection action (elastic#79834)
  [TSVB] Show tooltip on external pointer events (elastic#77306)
  Fixes bug where the same index was being passed in (elastic#79949)
  Adds date time query and return fields for timestamps and overrides (elastic#79911)
  [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920)
  add the correct class to truncate the names (elastic#79921)
  [kbn/optimizer] report limits with ci metrics (elastic#78205)
  [release notes] extract "dev docs" comment too (elastic#79351)
  Revert "skips test failing promotion (elastic#79777)" (elastic#79904)
  share tslib across bundles (elastic#79915)
  remove entire suite as partial skips aren't doing the trick
  skip flaky suite (elastic#78689)
  Skip failing suite (elastic#79522)
  skip flaky suite (elastic#79910)
  [es/mappings] remove doc_values from text fields (elastic#79869)
  remove skipped snapshots
  skip flaky tests (elastic#79891)
  chore(NA): add missing branches into backportrc configuration file (elastic#79848)
  ...
* master:
  [Telemetry] Telemetry tools check all `makeUsageCollector` calls (elastic#79840)
  Input controls crashes if index pattern is not available (elastic#79431)
* master:
  [ML] Fix job selection flyout (elastic#79850)
  Removed visualization:loadingDelay (elastic#79841)
  [Alerts] fix failing executionStatus function test with null deref (elastic#79809)
  Implemented trusted app name truncation. (elastic#79976)
* master: (23 commits)
  Table visualization renderer (elastic#79455)
  Migrate Jest JUnit reporter to TS (elastic#79919)
  store sorted bundleRefExportIds (elastic#80011)
  update chromedriver dependency to 86.0.0 (elastic#79972)
  [Security Solution][Case] Fix bug when changing connectors (elastic#80002)
  [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752)
  [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038)
  [Logs UI] Sync logs timerange with wider Kibana (elastic#79444)
  [DOCS] Adds quick start (elastic#78822)
  [Ingest Manager]Fix ingest manager UI renaming (elastic#80036)
  [Monitoring] Fixed internal monitoring check (elastic#79241)
  [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871)
  Update development documentation about REST API best practices (elastic#80009)
  [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190)
  [CI] Move kibana build dir outside of repo for functional tests (elastic#80018)
  [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013)
  [Enterprise Search] Added a Credentials page to App Search (elastic#79749)
  [DOCS] Canvas refresh for 7.10 (elastic#80017)
  [TSVB] Add ignore global filters to series options (elastic#79337)
  Remove this check (elastic#79202)
  ...
…mic-configs

* task-manager/health: (37 commits)
  updated docs
  fixed config mocks
  ensure we dont aggregate workload before tm is readyt
  make hot stats refresh rate configurable
  estimate recurring tasks in schedule
  fixed src import
  plug health into service status
  removed unused import
  Added health status in each section
  spaces -> tabs
  updated json in readme
  added readme
  change RGY to OK Error and Warn
  corrected types
  test status in aceptancve tests
  added status on health api
  fixed mock import
  fixed tests
  use APM agg types
  added upper bound to schedule density
  ...
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 12, 2020

💔 Build Failed

Failed CI Steps


Test Failures

Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/health_route·ts.task_manager health should return a breakdown of idleTasks in the task manager workload

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://dryrun

[00:00:00]       │
[00:00:00]         └-: task_manager
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: health
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should return basic configuration of task manager
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               └- ✓ pass  (13ms) "task_manager health should return basic configuration of task manager"
[00:00:00]             └-> should return the task manager workload
[00:00:00]               └-> "before each" hook: global before each
[00:00:03]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] [.kibana_task_manager_test_result] creating index, cause [auto(bulk api)], templates [], shards [1]/[1]
[00:00:03]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] [.kibana_task_manager_test_result/WW7IVT4JSA2vAghiCS7uwA] create_mapping
[00:00:05]               └- ✓ pass  (5.1s) "task_manager health should return the task manager workload"
[00:00:05]             └-> should return a breakdown of idleTasks in the task manager workload
[00:00:05]               └-> "before each" hook: global before each
[00:00:05]               └- ✖ fail: task_manager health should return a breakdown of idleTasks in the task manager workload
[00:00:05]               │       Error: expected 21 to sort of equal 20
[00:00:05]               │       + expected - actual
[00:00:05]               │ 
[00:00:05]               │       -21
[00:00:05]               │       +20
[00:00:05]               │       
[00:00:05]               │       at Assertion.assert (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:100:11)
[00:00:05]               │       at Assertion.eql (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:244:8)
[00:00:05]               │       at Context.it (test/plugin_api_integration/test_suites/task_manager/health_route.ts:155:50)
[00:00:05]               │ 
[00:00:05]               │ 

Stack Trace

{ Error: expected 21 to sort of equal 20
    at Assertion.assert (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/plugin_api_integration/test_suites/task_manager/health_route.ts:155:50) actual: '21', expected: '20', showDiff: true }

Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/health_route·ts.task_manager health should return a breakdown of idleTasks in the task manager workload

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: task_manager
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: health
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should return basic configuration of task manager
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               └- ✓ pass  (12ms) "task_manager health should return basic configuration of task manager"
[00:00:00]             └-> should return the task manager workload
[00:00:00]               └-> "before each" hook: global before each
[00:00:03]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] [.kibana_task_manager_test_result] creating index, cause [auto(bulk api)], templates [], shards [1]/[1]
[00:00:03]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] [.kibana_task_manager_test_result/Qecp69eQQ1y7C0hiHrvF9w] create_mapping
[00:00:03]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] [ilm-history-3-000001] creating index, cause [api], templates [ilm-history], shards [1]/[0]
[00:00:03]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] moving index [ilm-history-3-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:03]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] moving index [ilm-history-3-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [ilm-history-ilm-policy]
[00:00:03]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1602514953838832103] moving index [ilm-history-3-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [ilm-history-ilm-policy]
[00:00:05]               └- ✓ pass  (5.1s) "task_manager health should return the task manager workload"
[00:00:05]             └-> should return a breakdown of idleTasks in the task manager workload
[00:00:05]               └-> "before each" hook: global before each
[00:00:05]               └- ✖ fail: task_manager health should return a breakdown of idleTasks in the task manager workload
[00:00:05]               │       Error: expected 21 to sort of equal 20
[00:00:05]               │       + expected - actual
[00:00:05]               │ 
[00:00:05]               │       -21
[00:00:05]               │       +20
[00:00:05]               │       
[00:00:05]               │       at Assertion.assert (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:100:11)
[00:00:05]               │       at Assertion.eql (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:244:8)
[00:00:05]               │       at Context.it (test/plugin_api_integration/test_suites/task_manager/health_route.ts:155:50)
[00:00:05]               │ 
[00:00:05]               │ 

Stack Trace

{ Error: expected 21 to sort of equal 20
    at Assertion.assert (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/5/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/plugin_api_integration/test_suites/task_manager/health_route.ts:155:50) actual: '21', expected: '20', showDiff: true }

Metrics [docs]

distributable file count

id before after diff
default 48453 48464 +11

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris gmmorris closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants