[Alerts] fix failing executionStatus function test with null deref #79809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuellr
added
release_note:skip
Member
Author
|
jenkins retest this please |
Member
Author
|
flaky test runner passed 42 times - https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/893/ |
resolves elastic#79248 Added some additional checks for potential null/undefined objects before dereferencing them.
pmuellr
force-pushed
the
alerts/fix-broken-test-79248
branch
from
b8c6a69 to
a1b572f
Compare
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pmuellr
added
Feature:Alerting
Team:ResponseOps
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Oct 8, 2020
…lastic#79809) resolves elastic#79248 Added some additional checks for potential null/undefined objects before dereferencing them.
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Oct 8, 2020
…lastic#79809) resolves elastic#79248 Added some additional checks for potential null/undefined objects before dereferencing them.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 8, 2020
* master: [ML] Fix job selection flyout (elastic#79850) Removed visualization:loadingDelay (elastic#79841) [Alerts] fix failing executionStatus function test with null deref (elastic#79809) Implemented trusted app name truncation. (elastic#79976)
pmuellr
added a commit
that referenced
this pull request
Oct 8, 2020
pmuellr
added a commit
that referenced
this pull request
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #79248
Summary
Added some additional checks for potentially null/undefined objects before dereferencing them.