[Telemetry] Telemetry tools check all makeUsageCollector calls
#79840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
v8.0.0
release_note:skip
afharo
requested changes
Oct 7, 2020
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
Please, fix the broken tests and the types.
Also, I'm concerned we are actually changing the behaviour of the collectors. 0 is not the same to undefined (even for Elasticsearch 😅 )
src/plugins/vis_type_vega/server/usage_collector/get_usage_collector.ts
Outdated
Show resolved
Hide resolved
src/plugins/vis_type_vega/server/usage_collector/register_vega_collector.ts
Outdated
Show resolved
Hide resolved
afharo
reviewed
Oct 8, 2020
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
LGTM! I love these changes! Thank you!
afharo
approved these changes
Oct 8, 2020
alexwizp
approved these changes
Oct 8, 2020
Contributor
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 8, 2020
* master: [Telemetry] Telemetry tools check all `makeUsageCollector` calls (elastic#79840) Input controls crashes if index pattern is not available (elastic#79431)
Bamieh
added a commit
that referenced
this pull request
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Telemetry Team related changes:
makeUsageCollectoris not passed an object direcrly. only objects and variables defining an object are allowed.coreschema automatically added to mapping after check fixes.Kibana app related changes:
vis_type_vegacollector schema.visualization_typescollector schema.