Revert "Add support for runtime field types to mappings editor" #79611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#77420)" This reverts commit 0dc89cb.
cjcenizal
added
Feature:Index Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
sebelga
reviewed
Oct 6, 2020
| }; | ||
|
|
||
| export const getRequiredParametersFormForType = ( | ||
| export const getParametersFormForType = ( |
There was a problem hiding this comment.
Not sure why you had changed the name of the handler. 🤔 It correctly stated that it would return only the required parameters for a field type.
There was a problem hiding this comment.
Or am I reading this the other way around?? 😄
There was a problem hiding this comment.
Yes, I clarified the name in my original PR and this revert reintroduces the original, slightly more ambiguous name.
There was a problem hiding this comment.
OK, yes your change was indeed clearer 👍
|
Backported by #79612 |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Oct 7, 2020
…r. (elastic#77420)" (elastic#79611)" This reverts commit e01d538.
gmmorris
added a commit
that referenced
this pull request
Oct 8, 2020
…into feature/task_manager_429 * 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits) Add license check to direct package upload handler. (#79653) [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193) [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594) Fine-tunes ML related text on Metrics UI (#79425) [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229) Add new "Add Data" tutorials (#77237) Update APM telemetry docs (#79583) Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611) Kibana request headers (#79218) ensure missing indexPattern error is bubbled up to error callout (#79378) Missing space fix (#79585) remove duplicate tab states (#79501) [data.ui] Lazy load UI components in data plugin. (#78889) Add generic type params to search dependency. (#79608) [Ingest Manager] Internal action for policy reassign (#78493) [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175) [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579) [ML] Hide Data Grid column options when histogram charts are enabled. (#79459) [Telemetry] Synchronous `setup` and `start` methods (#79457) [Observability] Persist time range across apps (#79258) ...
cjcenizal
added a commit
that referenced
this pull request
Oct 12, 2020
…r. (#77420)" (#79611)" (#79940) This reverts commit e01d538. Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0dc89cb, introduced by #77420.