Skip to content

[ML] Fix job selection flyout #79850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 8, 2020
Merged

[ML] Fix job selection flyout #79850

merged 8 commits into from
Oct 8, 2020

Conversation

@darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 7, 2020 •
edited
Loading

Summary

Checklist

  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

@darnautov darnautov requested a review from a team as a code owner October 7, 2020 14:06
@darnautov darnautov self-assigned this Oct 7, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 7, 2020

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Oct 7, 2020

Tested and LGTM

peteharverson
peteharverson approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 8, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ml 11.2MB 11.2MB +5.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit 14b02a3 into elastic:master Oct 8, 2020
@darnautov darnautov deleted the ML-76932-fix-edit-swim-lane-flyout branch October 8, 2020 12:59
@darnautov darnautov mentioned this pull request Oct 8, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Oct 8, 2020
@darnautov
[ML] Fix job selection flyout (elastic#79850)
9213891 
* [ML] fix job selection flyout

* [ML] hide time range column

* [ML] show callout when no AD jobs presented

* [ML] close job selector flyout on navigating away from the dashboard

* [ML] add Create job button

* [ML] fix mocks

* [ML] add unit test for callout
@darnautov darnautov mentioned this pull request Oct 8, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 8, 2020
@gmmorris
Merge branch 'master' into task-manager/health
8223188 
* master:
  [ML] Fix job selection flyout (elastic#79850)
  Removed visualization:loadingDelay (elastic#79841)
  [Alerts] fix failing executionStatus function test with null deref (elastic#79809)
  Implemented trusted app name truncation. (elastic#79976)
darnautov added a commit that referenced this pull request Oct 8, 2020
@darnautov
[ML] Fix job selection flyout (#79850) (#79994)
9ab16bb 
* [ML] fix job selection flyout

* [ML] hide time range column

* [ML] show callout when no AD jobs presented

* [ML] close job selector flyout on navigating away from the dashboard

* [ML] add Create job button

* [ML] fix mocks

* [ML] add unit test for callout
darnautov added a commit that referenced this pull request Oct 8, 2020
@darnautov
[ML] Fix job selection flyout (#79850) (#79993)
856f74a 
* [ML] fix job selection flyout

* [ML] hide time range column

* [ML] show callout when no AD jobs presented

* [ML] close job selector flyout on navigating away from the dashboard

* [ML] add Create job button

* [ML] fix mocks

* [ML] add unit test for callout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@darnautov darnautov

Labels

:ml release_note:fix v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

5 participants

@darnautov @elasticmachine @qn895 @kibanamachine @peteharverson