Skip to content

[Metrics UI] Fix metrics threshold alert edit bugs#66105

Merged
phillipb merged 1 commit intoelastic:masterfrom
phillipb:fix-edit-flow-bugs
May 12, 2020
Merged

[Metrics UI] Fix metrics threshold alert edit bugs#66105
phillipb merged 1 commit intoelastic:masterfrom
phillipb:fix-edit-flow-bugs

Conversation

@phillipb
Copy link
Contributor

Summary

Fixes #66086 and an issue with displaying the proper window size and unit for an alert in edit mode.

@phillipb phillipb added release_note:fix Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 11, 2020
@phillipb phillipb requested a review from a team as a code owner May 11, 2020 20:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@phillipb phillipb changed the title Cleanup prefill and edit flow. [Metrics UI] Fix metrics threshold alert edit bugs May 11, 2020
@simianhacker simianhacker self-requested a review May 11, 2020 21:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipb phillipb merged commit 6d95b68 into elastic:master May 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 12, 2020
* master: (46 commits)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854)
  [functional/services] import By/until from module (elastic#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676)
  Inspect action shows on dashboard for every chart (elastic#65998)
  Fix heigt calc in calc issue for ie11 (elastic#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028)
  [SIEM] [Security] unified code structure phase 0 (elastic#65965)
  [Maps] Organize layers into subfolders (elastic#65513)
  skip flaky suite (elastic#59849)
  Cleanup prefill and edit flow. (elastic#66105)
  Fix major severity service map ring colors (elastic#66124)
  [DOCS] Improves formatting in action types (elastic#65932)
  [DOCS] APM Agent config: Setting values must be string (elastic#65875)
  Change default cert age limit value. (elastic#65918)
  [DOCS] Removed saved object options (elastic#66072)
  [SIEM] [Cases] Case API tests (elastic#65777)
  Add example of of local plugin installation (elastic#65986)
  skip flaky suite (elastic#65741)
  [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583)
  [Reporting/Test] Add Functional test for download CSV (elastic#65401)
  ...
phillipb added a commit to phillipb/kibana that referenced this pull request May 12, 2020
phillipb added a commit to phillipb/kibana that referenced this pull request May 12, 2020
jloleysens added a commit that referenced this pull request May 12, 2020
…ine-editor

* 'master' of github.com:elastic/kibana: (37 commits)
  [APM] Correct relative paths in scripts (#66159)
  [Uptime] Enable deselection of stale filters (#65523)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854)
  [functional/services] import By/until from module (#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (#65676)
  Inspect action shows on dashboard for every chart (#65998)
  Fix heigt calc in calc issue for ie11 (#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (#66028)
  [SIEM] [Security] unified code structure phase 0 (#65965)
  [Maps] Organize layers into subfolders (#65513)
  skip flaky suite (#59849)
  Cleanup prefill and edit flow. (#66105)
  Fix major severity service map ring colors (#66124)
  [DOCS] Improves formatting in action types (#65932)
  [DOCS] APM Agent config: Setting values must be string (#65875)
  Change default cert age limit value. (#65918)
  [DOCS] Removed saved object options (#66072)
  [SIEM] [Cases] Case API tests (#65777)
  Add example of of local plugin installation (#65986)
  skip flaky suite (#65741)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Metrics UI Metrics UI feature release_note:fix release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics UI] Editing filter for Metric Threshold Alerts throws error on save

4 participants