[Drilldowns][IE] fix welcome bar layout in IE#65676
Merged
Dosant merged 9 commits intoelastic:masterfrom May 12, 2020
Merged
Conversation
Dosant
added
bug
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
commented
May 7, 2020
| .drdHelloBar__content .drdHelloBar__contentWrapIE { | ||
| // flex-basis: auto doesn't wrap properly, | ||
| // so have to use static value that works for most cases | ||
| flex-basis: 480px; |
Contributor
Author
There was a problem hiding this comment.
flex-basis: auto; didn't work :(
flex-container overlapped the flyout causing endless horizontal scroll, as text inside is not wrapping.
@elastic/kibana-design if there is a magic tip, I'd appreciate it 🙏
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I checked at the flyout banner example from our EUI docs in IE, and it shows the layout working correctly. I compared to your instance of EuiCallOut, and noticed that you're putting all the content in the title of the EuiCallout instead passing it as the children. If you pass flex group and contents as the children, you shouldn't have any IE issues.
IE EUI Docs:
Contributor
Author
There was a problem hiding this comment.
@cchaos, mind hitting ✅ for Kibana-design?
streamich
approved these changes
May 7, 2020
Contributor
streamich
left a comment
streamich
left a comment
There was a problem hiding this comment.
LGTM. Let's see what Design team has to say.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/_async_dashboard·ts.dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2"Standard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
cchaos
approved these changes
May 11, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
I didn't test this exact branch locally, but I did test a similar implementation. Thanks for making the change to the content instead of the styles. 👍
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
May 12, 2020
* fix drilldown hello bar in IE * fix comment * use children instead of title for EuiCallOut content Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
May 12, 2020
* fix drilldown hello bar in IE * fix comment * use children instead of title for EuiCallOut content Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 12, 2020
* master: (46 commits) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854) [functional/services] import By/until from module (elastic#66015) [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676) Inspect action shows on dashboard for every chart (elastic#65998) Fix heigt calc in calc issue for ie11 (elastic#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028) [SIEM] [Security] unified code structure phase 0 (elastic#65965) [Maps] Organize layers into subfolders (elastic#65513) skip flaky suite (elastic#59849) Cleanup prefill and edit flow. (elastic#66105) Fix major severity service map ring colors (elastic#66124) [DOCS] Improves formatting in action types (elastic#65932) [DOCS] APM Agent config: Setting values must be string (elastic#65875) Change default cert age limit value. (elastic#65918) [DOCS] Removed saved object options (elastic#66072) [SIEM] [Cases] Case API tests (elastic#65777) Add example of of local plugin installation (elastic#65986) skip flaky suite (elastic#65741) [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583) [Reporting/Test] Add Functional test for download CSV (elastic#65401) ...
jloleysens
added a commit
that referenced
this pull request
May 12, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (37 commits) [APM] Correct relative paths in scripts (#66159) [Uptime] Enable deselection of stale filters (#65523) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854) [functional/services] import By/until from module (#66015) [Drilldowns][IE] fix welcome bar layout in IE (#65676) Inspect action shows on dashboard for every chart (#65998) Fix heigt calc in calc issue for ie11 (#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (#66028) [SIEM] [Security] unified code structure phase 0 (#65965) [Maps] Organize layers into subfolders (#65513) skip flaky suite (#59849) Cleanup prefill and edit flow. (#66105) Fix major severity service map ring colors (#66124) [DOCS] Improves formatting in action types (#65932) [DOCS] APM Agent config: Setting values must be string (#65875) Change default cert age limit value. (#65918) [DOCS] Removed saved object options (#66072) [SIEM] [Cases] Case API tests (#65777) Add example of of local plugin installation (#65986) skip flaky suite (#65741) ...
Dosant
added a commit
that referenced
this pull request
May 12, 2020
* fix drilldown hello bar in IE * fix comment * use children instead of title for EuiCallOut content Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
that referenced
this pull request
May 12, 2020
* fix drilldown hello bar in IE * fix comment * use children instead of title for EuiCallOut content Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #42845
This fixes bug in Drilldowns welcome bar layout in IE.
Before:
After:
To start in IE checkout this branch and:
Checklist