[Uptime] Enable deselection of stale filters#65523
Merged
shahzad31 merged 4 commits intoelastic:masterfrom May 12, 2020
Merged
Conversation
botelastic
bot
added
the
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
added
the
bug
Contributor
Author
|
@elasticmachine merge upstream |
justinkambic
approved these changes
May 11, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Great improvement. I tested this locally and it worked great, included a GIP summary. Please fix the one comment I mentioned.
LGTM
Comment on lines
52
to
53
| // Merge incoming items with selected items, to enable un-selection | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| // Merge incoming items with selected items, to enable un-selection | |
| // Merge incoming items with selected items, to enable deselection |
Small english nitpick.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 12, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 12, 2020
* master: [Uptime] Enable deselection of stale filters (elastic#65523)
jloleysens
added a commit
that referenced
this pull request
May 12, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (37 commits) [APM] Correct relative paths in scripts (#66159) [Uptime] Enable deselection of stale filters (#65523) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854) [functional/services] import By/until from module (#66015) [Drilldowns][IE] fix welcome bar layout in IE (#65676) Inspect action shows on dashboard for every chart (#65998) Fix heigt calc in calc issue for ie11 (#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (#66028) [SIEM] [Security] unified code structure phase 0 (#65965) [Maps] Organize layers into subfolders (#65513) skip flaky suite (#59849) Cleanup prefill and edit flow. (#66105) Fix major severity service map ring colors (#66124) [DOCS] Improves formatting in action types (#65932) [DOCS] APM Agent config: Setting values must be string (#65875) Change default cert age limit value. (#65918) [DOCS] Removed saved object options (#66072) [SIEM] [Cases] Case API tests (#65777) Add example of of local plugin installation (#65986) skip flaky suite (#65741) ...
shahzad31
added a commit
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
that referenced
this pull request
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65059
In overview page and monitor status alert, user wasn't able to deselect stale filters after kuery bar search is updated, this patch fixes that.