[Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components by Dosant · Pull Request #65854 · elastic/kibana

Dosant · 2020-05-08T14:01:56Z

Summary

Part of #42845

this removes some of not needed any from components
also removes PlaceContext. We removed it from service layer, but didn't from components (remove for now)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-05-08T14:01:59Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

Dosant · 2020-05-08T14:03:17Z

...ugins/drilldowns/public/components/flyout_drilldown_wizard/flyout_drilldown_wizard.story.tsx

          onClose={() => {}}
-          drilldownActionFactories={[urlFactory, dashboardFactory]}
+          drilldownActionFactories={[
+            urlFactory as ActionFactory,


Here and in other places in this test have to downcast now because of how array types compatibility work

flash1293 · 2020-05-08T17:53:26Z

It seems like the new “sample data dashboard” functional test failed once on this Pr as well. I have the same problem on my cutover Pr - I tried to stabilize it over there and it seems like it’s helping - if it becomes a problem we can also merge this sooner than the cutover Pr itself.

stacey-gammon

Thanks so much for doing this Anton!

I started digging into the casting issue. Unfortunately I can't come up with any good work around, so, lgtm.

Code review only.

Dosant · 2020-05-11T05:35:08Z

@elasticmachine merge upstream

…ents

kibanamachine · 2020-05-11T07:36:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8807fc2

History

💔 Build #46625 failed 6bc22b1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson

Tested locally on chrome by creating and using dashboard drilldowns. Everything LGTM.

QQ: Isn't the current dashboard supposed to be hidden in the options for drilldowns? It doesn't break anything by being there, but it's maybe a small QOL thing. If I'm not mistaken, this is the responsibility of PlaceContext, and it should be restored after PlaceContext is re-introduced. Is that the case?

stacey-gammon · 2020-05-11T18:30:49Z

QQ: Isn't the current dashboard supposed to be hidden in the options for drilldowns?

There was an iteration that did that, but the code was removed bc it relied on dashboardEmbeddable.input.id being the saved object id, and that is not necessarily the case. Ideally, we'd have a dashboard by reference embeddable and use dashboardEmbeddableRef.input.savedObjectId.

…ontext` from components (elastic#65854) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (46 commits) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854) [functional/services] import By/until from module (elastic#66015) [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676) Inspect action shows on dashboard for every chart (elastic#65998) Fix heigt calc in calc issue for ie11 (elastic#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028) [SIEM] [Security] unified code structure phase 0 (elastic#65965) [Maps] Organize layers into subfolders (elastic#65513) skip flaky suite (elastic#59849) Cleanup prefill and edit flow. (elastic#66105) Fix major severity service map ring colors (elastic#66124) [DOCS] Improves formatting in action types (elastic#65932) [DOCS] APM Agent config: Setting values must be string (elastic#65875) Change default cert age limit value. (elastic#65918) [DOCS] Removed saved object options (elastic#66072) [SIEM] [Cases] Case API tests (elastic#65777) Add example of of local plugin installation (elastic#65986) skip flaky suite (elastic#65741) [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583) [Reporting/Test] Add Functional test for download CSV (elastic#65401) ...

…ine-editor * 'master' of github.com:elastic/kibana: (37 commits) [APM] Correct relative paths in scripts (#66159) [Uptime] Enable deselection of stale filters (#65523) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854) [functional/services] import By/until from module (#66015) [Drilldowns][IE] fix welcome bar layout in IE (#65676) Inspect action shows on dashboard for every chart (#65998) Fix heigt calc in calc issue for ie11 (#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (#66028) [SIEM] [Security] unified code structure phase 0 (#65965) [Maps] Organize layers into subfolders (#65513) skip flaky suite (#59849) Cleanup prefill and edit flow. (#66105) Fix major severity service map ring colors (#66124) [DOCS] Improves formatting in action types (#65932) [DOCS] APM Agent config: Setting values must be string (#65875) Change default cert age limit value. (#65918) [DOCS] Removed saved object options (#66072) [SIEM] [Cases] Case API tests (#65777) Add example of of local plugin installation (#65986) skip flaky suite (#65741) ...

…ontext` from components (#65854) (#66167) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

chore refactors

6bc22b1

Dosant added chore v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns v7.9.0 labels May 8, 2020

Dosant requested a review from a team May 8, 2020 14:01

Dosant requested a review from a team as a code owner May 8, 2020 14:01

Dosant commented May 8, 2020

View reviewed changes

Dosant requested review from stacey-gammon and streamich May 8, 2020 14:04

streamich approved these changes May 8, 2020

View reviewed changes

stacey-gammon approved these changes May 8, 2020

View reviewed changes

Merge branch 'master' into dev/drilldowns/remove-some-any-from-compon…

8807fc2

…ents

Dosant mentioned this pull request May 11, 2020

async_dashboard flaky test #65966

Closed

Dosant requested a review from ThomThomson May 11, 2020 08:14

ThomThomson approved these changes May 11, 2020

View reviewed changes

Dosant merged commit 0f5c1ed into elastic:master May 12, 2020

Dosant mentioned this pull request May 12, 2020

[7.x] [Drilldowns][chore] Remove some any's from components. Remove PlaceContext from components (#65854) #66167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components#65854

[Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components#65854
Dosant merged 2 commits intoelastic:masterfrom
Dosant:dev/drilldowns/remove-some-any-from-components

Dosant commented May 8, 2020 •

edited

Loading

Uh oh!

elasticmachine commented May 8, 2020

Uh oh!

Dosant May 8, 2020 •

edited

Loading

Uh oh!

flash1293 commented May 8, 2020

Uh oh!

stacey-gammon left a comment •

edited

Loading

Uh oh!

Dosant commented May 11, 2020

Uh oh!

kibanamachine commented May 11, 2020

Uh oh!

ThomThomson left a comment •

edited

Loading

Uh oh!

stacey-gammon commented May 11, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Dosant commented May 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented May 8, 2020

Uh oh!

Dosant May 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flash1293 commented May 8, 2020

Uh oh!

stacey-gammon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dosant commented May 11, 2020

Uh oh!

kibanamachine commented May 11, 2020

💚 Build Succeeded

History

Uh oh!

ThomThomson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stacey-gammon commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Dosant commented May 8, 2020 •

edited

Loading

Dosant May 8, 2020 •

edited

Loading

stacey-gammon left a comment •

edited

Loading

ThomThomson left a comment •

edited

Loading

stacey-gammon commented May 11, 2020 •

edited

Loading