[Dev Tools] Fix height calc in calc issue for ie11#66010
Merged
jloleysens merged 1 commit intoelastic:masterfrom May 12, 2020
Merged
[Dev Tools] Fix height calc in calc issue for ie11#66010jloleysens merged 1 commit intoelastic:masterfrom
jloleysens merged 1 commit intoelastic:masterfrom
Conversation
jloleysens
added
Feature:Dev Tools
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
cjcenizal
approved these changes
May 11, 2020
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, code LGTM! I have no idea how to solve that 1px scroll issue, but it doesn't prevent the user from accessing any functionality, so I think it's acceptable.
Contributor
Author
|
@cjcenizal Thanks for the review! I am inclined to agree that the problem is acceptable since it is really only scoped to IE11. I've updated my PR description to point out that the problem also exists on FF in Painless Lab. I'll open an issue to investigate further as these are minor annoyances, but they should be fixed. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 12, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 12, 2020
This was referenced May 12, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 12, 2020
* master: (46 commits) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854) [functional/services] import By/until from module (elastic#66015) [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676) Inspect action shows on dashboard for every chart (elastic#65998) Fix heigt calc in calc issue for ie11 (elastic#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028) [SIEM] [Security] unified code structure phase 0 (elastic#65965) [Maps] Organize layers into subfolders (elastic#65513) skip flaky suite (elastic#59849) Cleanup prefill and edit flow. (elastic#66105) Fix major severity service map ring colors (elastic#66124) [DOCS] Improves formatting in action types (elastic#65932) [DOCS] APM Agent config: Setting values must be string (elastic#65875) Change default cert age limit value. (elastic#65918) [DOCS] Removed saved object options (elastic#66072) [SIEM] [Cases] Case API tests (elastic#65777) Add example of of local plugin installation (elastic#65986) skip flaky suite (elastic#65741) [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583) [Reporting/Test] Add Functional test for download CSV (elastic#65401) ...
jloleysens
added a commit
that referenced
this pull request
May 12, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (37 commits) [APM] Correct relative paths in scripts (#66159) [Uptime] Enable deselection of stale filters (#65523) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854) [functional/services] import By/until from module (#66015) [Drilldowns][IE] fix welcome bar layout in IE (#65676) Inspect action shows on dashboard for every chart (#65998) Fix heigt calc in calc issue for ie11 (#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (#66028) [SIEM] [Security] unified code structure phase 0 (#65965) [Maps] Organize layers into subfolders (#65513) skip flaky suite (#59849) Cleanup prefill and edit flow. (#66105) Fix major severity service map ring colors (#66124) [DOCS] Improves formatting in action types (#65932) [DOCS] APM Agent config: Setting values must be string (#65875) Change default cert age limit value. (#65918) [DOCS] Removed saved object options (#66072) [SIEM] [Cases] Case API tests (#65777) Add example of of local plugin installation (#65986) skip flaky suite (#65741) ...
jloleysens
added a commit
that referenced
this pull request
May 12, 2020
jloleysens
added a commit
that referenced
this pull request
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #64018 was merged Console, Searchprofiler and Painless Lab no longer render correctly on IE11:
Console
Searchprofiler
It looks like this is related to use of
calcincalc, so instead we use SCSS to do the calculations. The Dev Tools that are fixed height still render with a sidebar and can scroll ~1px. This only happens on IE11 in Console, SearchProfiler and Painless. The same thing happens on FF for Painless Lab.Any advice on how to fix would be greatly appreciated.
Tested on FF, Chrome, Safari and IE11.
How to test
window.__kbnCspNotEnforced__ = true;towindow.__kbnCspNotEnforced__ = false;(hacky, not sure how this works otherwise)Checklist
For maintainers