Refresh index pattern list before redirecting by flash1293 · Pull Request #63329 · elastic/kibana

flash1293 · 2020-04-13T08:23:58Z

Summary

Before redirecting to the management page because no index pattern is available, refresh the cached index pattern list. This prevents a confusing (and unnecessary) redirect to the management page when accessing Discover/Visualize/Dashboard in a bunch of situations because the index pattern cache can become stale e.g. when importing a saved object.

Initially I was refreshing the cache every time the ensureDefaultIndexPattern helper was called, but this slows down a lot of page navigations (e.g. switching between visualizations), so I moved it to the mount callbacks of the individual apps.

flash1293 · 2020-04-13T09:56:14Z

@elasticmachine merge upstream

…-refresh-bug

flash1293 · 2020-04-14T15:04:13Z

@elasticmachine merge upstream

…-refresh-bug

…kibana into fix-index-pattern-refresh-bug

flash1293 · 2020-04-15T11:20:30Z

test/functional/page_objects/dashboard_page.ts

    public async clickNewDashboard() {
      await listingTable.clickNewButton('createDashboardPromptButton');
+      // make sure the dashboard page is shown
+      await this.waitForRenderComplete();


When switching to a dashboard, we introduce an additional delay with this change because another network roundtrip is necessary. This stabilizes the test so it doesn't fail.

elasticmachine · 2020-04-16T07:31:22Z

Pinging @elastic/kibana-app (Team:KibanaApp)

…-refresh-bug

flash1293 · 2020-04-17T09:39:14Z

@kertal Moved the fix for index pattern deletion over here as well.

lizozom · 2020-04-19T11:05:01Z

...ns/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js

        Promise.resolve($scope.indexPattern.destroy())
          .then(function() {
+            npStart.plugins.data.indexPatterns.clearCache();
            $location.url('/management/kibana/index_patterns');


Wouldn't it be better if we clear the index pattern cache upon arrival to management?
Otherwise, if we get to that route from a different path, we'll have different behaviors.

I'm just realizing we don't even need this clear cache to fix the bug because it already gets cleared when switching over to discover.

The index pattern listing in management is not affected by this because it's using the raw saved object client.

I will just revert this line.

…-refresh-bug

flash1293 · 2020-04-21T06:38:20Z

@elasticmachine merge upstream

kertal · 2020-04-21T06:41:31Z

ACK, will review today

kibanamachine · 2020-04-21T08:15:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 20387b0

History

💚 Build #41888 succeeded 2b81cbc
💛 Build #41521 was flaky b9cc865
💚 Build #40891 succeeded 23aced7
💔 Build #40872 failed 8beff0e
💔 Build #40678 failed 7afde20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lizozom

LGTM

kertal

Code LGTM, fixes also: #62269, tested locally in Chrome80, deleted index patterns no longer show up in the index pattern selection, so the cache is deleted, and all problems dependent to this invalid cache is solved

* master: (29 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...

…ana into task-manager/cancel-logging * 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...

refresh index pattern list before redirecting

1c3e50c

flash1293 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.7.1 labels Apr 13, 2020

elasticmachine and others added 2 commits April 13, 2020 05:56

Merge branch 'master' into fix-index-pattern-refresh-bug

c91e1db

Merge remote-tracking branch 'upstream/master' into fix-index-pattern…

a95e4f5

…-refresh-bug

elasticmachine and others added 5 commits April 14, 2020 11:04

Merge branch 'master' into fix-index-pattern-refresh-bug

7afde20

Merge remote-tracking branch 'upstream/master' into fix-index-pattern…

44aaf29

…-refresh-bug

move index pattern list refresh to app level and stabilize a11y test

9052c9f

Merge branch 'fix-index-pattern-refresh-bug' of github.com:flash1293/…

8beff0e

…kibana into fix-index-pattern-refresh-bug

fix discover index refreshing

23aced7

flash1293 marked this pull request as ready for review April 15, 2020 11:19

flash1293 requested a review from a team April 15, 2020 11:19

flash1293 commented Apr 15, 2020

View reviewed changes

flash1293 added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Apr 16, 2020

flash1293 mentioned this pull request Apr 16, 2020

Clear cache when index pattern is deleted #63220

Closed

1 task

flash1293 added 2 commits April 17, 2020 11:36

Merge remote-tracking branch 'upstream/master' into fix-index-pattern…

b2fbf75

…-refresh-bug

fix elastic#63180 as well

441c60f

flash1293 requested a review from a team as a code owner April 17, 2020 09:38

fix merge conflict

b9cc865

lizozom reviewed Apr 19, 2020

View reviewed changes

flash1293 mentioned this pull request Apr 20, 2020

[Discover] Prevent error message of read only user without default index pattern set #54122

Closed

flash1293 added 2 commits April 20, 2020 16:42

Merge remote-tracking branch 'upstream/master' into fix-index-pattern…

e923d7d

…-refresh-bug

revert cache clearning in management

2b81cbc

Merge branch 'master' into fix-index-pattern-refresh-bug

20387b0

kertal self-requested a review April 21, 2020 06:41

lizozom approved these changes Apr 21, 2020

View reviewed changes

kertal approved these changes Apr 21, 2020

View reviewed changes

flash1293 merged commit 2f794e6 into elastic:master Apr 22, 2020

flash1293 mentioned this pull request Apr 22, 2020

[7.x] Refresh index pattern list before redirecting (#63329) #64140

Merged

flash1293 added a commit to flash1293/kibana that referenced this pull request Apr 22, 2020

Refresh index pattern list before redirecting (elastic#63329)

edd2c45

flash1293 added a commit that referenced this pull request Apr 22, 2020

Refresh index pattern list before redirecting (#63329) (#64140)

f3822e1

flash1293 added v7.9.0 and removed v7.7.1 labels May 8, 2020

kertal mentioned this pull request Jun 16, 2020

Reactify visualize app #67848

Merged

7 tasks

Dosant mentioned this pull request Dec 10, 2020

Bug: Kibana shows the wrong screen (index pattern creation) even if there are index patterns in the space #45748

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refresh index pattern list before redirecting#63329

Refresh index pattern list before redirecting#63329
flash1293 merged 14 commits intoelastic:masterfrom
flash1293:fix-index-pattern-refresh-bug

flash1293 commented Apr 13, 2020 •

edited

Loading

Uh oh!

flash1293 commented Apr 13, 2020

Uh oh!

flash1293 commented Apr 14, 2020

Uh oh!

flash1293 Apr 15, 2020

Uh oh!

elasticmachine commented Apr 16, 2020

Uh oh!

flash1293 commented Apr 17, 2020

Uh oh!

lizozom Apr 19, 2020

Uh oh!

flash1293 Apr 20, 2020

Uh oh!

flash1293 commented Apr 21, 2020

Uh oh!

kertal commented Apr 21, 2020

Uh oh!

kibanamachine commented Apr 21, 2020

Uh oh!

lizozom left a comment

Uh oh!

kertal left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

flash1293 commented Apr 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

flash1293 commented Apr 13, 2020

Uh oh!

flash1293 commented Apr 14, 2020

Uh oh!

flash1293 Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 16, 2020

Uh oh!

flash1293 commented Apr 17, 2020

Uh oh!

lizozom Apr 19, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Apr 21, 2020

Uh oh!

kertal commented Apr 21, 2020

Uh oh!

kibanamachine commented Apr 21, 2020

💚 Build Succeeded

History

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

flash1293 commented Apr 13, 2020 •

edited

Loading